`stellar contract invoke` can't find a signer by its public keys

[ifropc]

What version are you using?

Latest

What did you do?

1. Call invoke passing --admin by its public key -> fails

[ ~/projects/goldsky ] > stellar contract invoke --id CBC7JZTXRS7X6DCX6DRCI2NFJJI4BXYPTPOGVG3GPHH27OMPKR434BSX -- deploy --wasm-name increment --contract-name test --admin GAPGYTYEYIHW5TXR2EBF7FE26P2JELDMZKO3P4SJGPJTHMX33VCXSKV7
ℹ️  Simulating transaction…
❌ error: Missing signing key for account GAPGYTYEYIHW5TXR2EBF7FE26P2JELDMZKO3P4SJGPJTHMX33VCXSKV7

2. Call invoke passing --admin by identity (alice) -> ok

[ ~/projects/goldsky ] > stellar contract invoke --id CBC7JZTXRS7X6DCX6DRCI2NFJJI4BXYPTPOGVG3GPHH27OMPKR434BSX -- deploy --wasm-name increment --contract-name test --admin alice
ℹ️  Simulating transaction…
ℹ️  Signing transaction: 5c4b70bf68e1a76eba23e0ea5df56e46cc7a112b13407d09b3c048218cd3f060
🌎 Sending transaction…
✅ Transaction submitted successfully!
🔗 https://stellar.expert/explorer/testnet/tx/5c4b70bf68e1a76eba23e0ea5df56e46cc7a112b13407d09b3c048218cd3f060
📅 CBC7JZTXRS7X6DCX6DRCI2NFJJI4BXYPTPOGVG3GPHH27OMPKR434BSX - Success - Event: Deploy (deploy), wasm_name: "increment", version: "1.0.0", deployer: "CBC7JZTXRS7X6DCX6DRCI2NFJJI4BXYPTPOGVG3GPHH27OMPKR434BSX", contract_id: "CB5GUINWUNEIGCQ2KN6633DPPY57YNCFQVV7YMMOCY4GIJS5L7BVFN5S"
📅 CBC7JZTXRS7X6DCX6DRCI2NFJJI4BXYPTPOGVG3GPHH27OMPKR434BSX - Success - Event: Register (register), contract_name: "test", contract_id: "CB5GUINWUNEIGCQ2KN6633DPPY57YNCFQVV7YMMOCY4GIJS5L7BVFN5S", sac: false, wasm_hash: "3e590fe335b9c078ff4fccfd896dd38ce652b4c7d9360d3ad641e52d528f0d81"
"CB5GUINWUNEIGCQ2KN6633DPPY57YNCFQVV7YMMOCY4GIJS5L7BVFN5S"

3. Showing the store

[ ~/projects/goldsky ] > stellar keys ls                                         
alice
me
[ ~/projects/goldsky ] > stellar keys public-key alice
GAPGYTYEYIHW5TXR2EBF7FE26P2JELDMZKO3P4SJGPJTHMX33VCXSKV7
[ ~/projects/goldsky ] > stellar keys show alice      
S*******

What did you expect to see?

Contract invoking passing admin by its public key works

What did you see instead?

Missing signing key for account, even though key is not missing at all

[ifropc]

The problem seems to be in resolve_signer that calls get_secret_key which in turn recognizes GAPGYTYEYIHW5TXR2EBF7FE26P2JELDMZKO3P4SJGPJTHMX33VCXSKV7 as public key and (falsely) draws a conclusion that I don't have a private key for it.
Unfortunately the fix is not trivial. We could maybe iterate over all known and accessible keys in storage(s) and check if the key belongs to it?

[chadoh]

We don’t even need the secret key for public keys passed as function arguments, though! This error is doubly irrelevant. If public keys are passed for account IDs to function arguments, no resolution is needed. It’s the simplest possible case.