Add Boost Software License and update README

pratzl · pratzl · commit b576fd4f288a · 2026-01-22T08:30:54.000-05:00
- Add LICENSE file with Boost Software License 1.0
- Update README.md to reflect Phase 8 completion
  - Document all three graph containers (dynamic_graph, compressed_graph, undirected_adjacency_list)
  - Update test statistics (3866 tests, 36004 assertions)
  - Add license reference to README
- Refactor undirected_adjacency_list to use dedicated value classes
  - Replace graph_value_wrapper/conditional inheritance with ual_edge_value/ual_vertex_value
  - Add GV=void specialization removing graph_value_ overhead
  - Fix all base_type references to use base_value_type
  - Update graph value storage to use [[no_unique_address]] member
diff --git a/LICENSE b/LICENSE
@@ -0,0 +1,23 @@
+Boost Software License - Version 1.0 - August 17th, 2003
+
+Permission is hereby granted, free of charge, to any person or organization
+obtaining a copy of the software and accompanying documentation covered by
+this license (the "Software") to use, reproduce, display, distribute,
+execute, and transmit the Software, and to prepare derivative works of the
+Software, and to permit third-parties to whom the Software is furnished to
+do so, all subject to the following:
+
+The copyright notices in the Software and this entire statement, including
+the above license grant, this restriction and the following disclaimer,
+must be included in all copies of the Software, in whole or in part, and
+all derivative works of the Software, unless such copies or derivative
+works are solely in the form of machine-executable object code generated by
+a source language processor.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE, TITLE AND NON-INFRINGEMENT. IN NO EVENT
+SHALL THE COPYRIGHT HOLDERS OR ANYONE DISTRIBUTING THE SOFTWARE BE LIABLE
+FOR ANY DAMAGES OR OTHER LIABILITY, WHETHER IN CONTRACT, TORT OR OTHERWISE,
+ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+DEALINGS IN THE SOFTWARE.
diff --git a/README.md b/README.md
@@ -12,7 +12,7 @@ This library provides the foundation for a complete graph library following the
 - **Range-Based Design**: Graphs as ranges of vertices, where each vertex is a range of edges
 - **Documentation**: Comprehensive documentation following P1709 conventions
 
-**Current Status**: Phase 7 complete - All core CPOs, value access CPOs, optional partitioning/sourced edge CPOs, adjacency list concepts, and adjacency list traits implemented with comprehensive tests. Ready for first container implementation.
+**Current Status**: Phase 8 complete - All graph containers implemented (`dynamic_graph`, `compressed_graph`, `undirected_adjacency_list`) with comprehensive test coverage (3866 tests, 36004 assertions). Core CPOs, value access CPOs, partitioning/sourced edge CPOs, adjacency list concepts, and traits are all fully implemented.
 
 ## Features
 
@@ -418,7 +418,25 @@ Unit tests and documentation for each CPO added.
     * Runtime verification tests for trait correctness
     * Integration tests with existing CPO framework
 
-### 📋 Phase 8: First Container Implementation (PLANNED)
+### ✅ Phase 8: Graph Container Implementations (COMPLETE)
+- [x] **dynamic_graph** - Flexible directed graph with configurable vertex/edge containers ✅
+  - Multiple container combinations: vector-of-vector (vov), vector-of-list (vol), vector-of-forward_list (vofl)
+  - Partition support for distributed/NUMA-aware graphs
+  - Sourced edges optional (track source vertex in edge)
+  - Comprehensive test coverage: 1000+ test cases
+- [x] **compressed_graph** - Read-only compressed sparse row (CSR) format ✅
+  - Optimal for static graph algorithms
+  - Minimal memory footprint
+  - O(1) vertex access, O(degree) edge iteration
+  - Partition support
+- [x] **undirected_adjacency_list** - Undirected graph with dual-list design ✅
+  - Each edge stored in two linked lists (one per endpoint)
+  - O(1) edge removal from both vertices
+  - Template defaults aligned with other graphs (VV, EV, GV default to `void`)
+  - Modern `eproj` constructor pattern (consistent with dynamic_graph)
+  - 94 test cases, 525 assertions
+  - Full CPO conformance (47+ functions)
+
 ### 📋 Phase 9: Basic Algorithms (PLANNED)
 - [ ] Foundational algorithms in `include/graph/algorithm/`:
   - `breadth_first_search.hpp` - BFS traversal
@@ -465,13 +483,16 @@ desc/
 │       └── graph_utility.hpp       # Utility CPOs (stub)
 ├── scripts/                # Build and maintenance scripts
 │   └── format.sh          # Code formatting script
-├── tests/                  # Unit tests (535 tests, all passing)
+├── tests/                  # Unit tests (3866 tests, all passing)
 │   ├── test_adjacency_list_edge_concepts.cpp
 │   ├── test_adjacency_list_traits.cpp
 │   ├── test_adjacency_list_vertex_concepts.cpp
+│   ├── test_compressed_graph.cpp
+│   ├── test_compressed_graph_cpo.cpp
 │   ├── test_contains_edge_cpo.cpp
 │   ├── test_degree_cpo.cpp
 │   ├── test_descriptor_traits.cpp
+│   ├── test_dynamic_graph_*.cpp      # Multiple dynamic_graph test files
 │   ├── test_edge_concepts.cpp
 │   ├── test_edge_descriptor.cpp
 │   ├── test_edge_value_cpo.cpp
@@ -488,6 +509,8 @@ desc/
 │   ├── test_target_cpo.cpp
 │   ├── test_target_id_cpo.cpp
 │   ├── test_type_aliases.cpp
+│   ├── test_undirected_adjacency_list.cpp
+│   ├── test_undirected_adjacency_list_cpo.cpp
 │   ├── test_vertex_concepts.cpp
 │   ├── test_vertex_descriptor.cpp
 │   ├── test_vertex_id_cpo.cpp
@@ -722,7 +745,7 @@ Contributions are welcome! Please:
 
 ## License
 
-[License information to be determined]
+This library is distributed under the [Boost Software License 1.0](LICENSE). See the [LICENSE](LICENSE) file for details.
 
 ## Acknowledgments
 
diff --git a/include/graph/container/detail/undirected_adjacency_list_impl.hpp b/include/graph/container/detail/undirected_adjacency_list_impl.hpp
@@ -527,7 +527,7 @@ template <typename VV,
 ual_edge<VV, EV, GV, VId, VContainer, Alloc>::ual_edge(graph_type&     g,
                                                         vertex_key_type ukey,
                                                         vertex_key_type vkey) noexcept
-      : base_type(), vertex_edge_list_inward_link_type(ukey), vertex_edge_list_outward_link_type(vkey) {
+      : base_value_type(), vertex_edge_list_inward_link_type(ukey), vertex_edge_list_outward_link_type(vkey) {
   link_back(g.vertices()[ukey], g.vertices()[vkey]);
 }
 
@@ -542,7 +542,7 @@ ual_edge<VV, EV, GV, VId, VContainer, Alloc>::ual_edge(graph_type&            g,
                                                         vertex_key_type        ukey,
                                                         vertex_key_type        vkey,
                                                         const edge_value_type& val) noexcept
-      : base_type(val), vertex_edge_list_inward_link_type(ukey), vertex_edge_list_outward_link_type(vkey) {
+      : base_value_type(val), vertex_edge_list_inward_link_type(ukey), vertex_edge_list_outward_link_type(vkey) {
   link_back(g.vertices()[ukey], g.vertices()[vkey]);
 }
 
@@ -557,7 +557,7 @@ ual_edge<VV, EV, GV, VId, VContainer, Alloc>::ual_edge(graph_type&       g,
                                                         vertex_key_type   ukey,
                                                         vertex_key_type   vkey,
                                                         edge_value_type&& val) noexcept
-      : base_type(move(val)), vertex_edge_list_inward_link_type(ukey), vertex_edge_list_outward_link_type(vkey) {
+      : base_value_type(move(val)), vertex_edge_list_inward_link_type(ukey), vertex_edge_list_outward_link_type(vkey) {
   link_back(g.vertices()[ukey], g.vertices()[vkey]);
 }
 
@@ -569,7 +569,7 @@ template <typename VV,
           class VContainer,
           typename Alloc>
 ual_edge<VV, EV, GV, VId, VContainer, Alloc>::ual_edge(graph_type& g, vertex_iterator ui, vertex_iterator vi) noexcept
-      : base_type()
+      : base_value_type()
       , vertex_edge_list_inward_link_type(vertex_key(g, ui))
       , vertex_edge_list_outward_link_type(vertex_key(g, vi)) {
   link_back(*ui, *vi);
@@ -586,7 +586,7 @@ ual_edge<VV, EV, GV, VId, VContainer, Alloc>::ual_edge(graph_type&            g,
                                                         vertex_iterator        ui,
                                                         vertex_iterator        vi,
                                                         const edge_value_type& val) noexcept
-      : base_type(val)
+      : base_value_type(val)
       , vertex_edge_list_inward_link_type(vertex_key(g, ui))
       , vertex_edge_list_outward_link_type(vertex_key(g, vi)) {
   link_back(*ui, *vi);
@@ -603,7 +603,7 @@ ual_edge<VV, EV, GV, VId, VContainer, Alloc>::ual_edge(graph_type&       g,
                                                         vertex_iterator   ui,
                                                         vertex_iterator   vi,
                                                         edge_value_type&& val) noexcept
-      : base_type(move(val))
+      : base_value_type(move(val))
       , vertex_edge_list_inward_link_type(vertex_key(g, ui))
       , vertex_edge_list_outward_link_type(vertex_key(g, vi)) {
   link_back(*ui, *vi);
@@ -843,7 +843,7 @@ template <typename VV,
 ual_vertex<VV, EV, GV, VId, VContainer, Alloc>::ual_vertex([[maybe_unused]] vertex_set& vertices,
                                                             [[maybe_unused]] vertex_index index,
                                                             const vertex_value_type& val)
-      : base_type(val) {}
+      : base_value_type(val) {}
 template <typename VV,
           typename EV,
           typename GV,
@@ -854,7 +854,7 @@ template <typename VV,
 ual_vertex<VV, EV, GV, VId, VContainer, Alloc>::ual_vertex([[maybe_unused]] vertex_set& vertices,
                                                             [[maybe_unused]] vertex_index index,
                                                             vertex_value_type&& val) noexcept
-      : base_type(move(val)) {}
+      : base_value_type(move(val)) {}
 
 
 template <typename VV,
@@ -1181,7 +1181,7 @@ template <typename GV_>
   requires (!std::is_void_v<GV_> && !std::is_same_v<std::remove_cvref_t<GV_>, undirected_adjacency_list<VV, EV, GV, VId, VContainer, Alloc>>)
 undirected_adjacency_list<VV, EV, GV, VId, VContainer, Alloc>::undirected_adjacency_list(const GV_& val,
                                                                                           const allocator_type&   alloc)
-      : base_type(val), vertices_(alloc), edge_alloc_(alloc) {}
+      : vertices_(alloc), edge_alloc_(alloc), graph_value_(val) {}
 
 template <typename VV,
           typename EV,
@@ -1194,7 +1194,7 @@ template <typename GV_>
   requires (!std::is_void_v<GV_> && !std::is_same_v<std::remove_cvref_t<GV_>, undirected_adjacency_list<VV, EV, GV, VId, VContainer, Alloc>>)
 undirected_adjacency_list<VV, EV, GV, VId, VContainer, Alloc>::undirected_adjacency_list(GV_&&    val,
                                                                                           const allocator_type& alloc)
-      : base_type(std::forward<GV_>(val)), vertices_(alloc), edge_alloc_(alloc) {}
+      : vertices_(alloc), edge_alloc_(alloc), graph_value_(std::forward<GV_>(val)) {}
 
 
 // clang-format off
@@ -1211,7 +1211,7 @@ undirected_adjacency_list<VV, EV, GV, VId, VContainer, Alloc>::undirected_adjace
                                                                               const VProj& vproj,
                                                                               const GV_&   gv,
                                                                               const Alloc& alloc)
-      : base_type(gv), vertices_(alloc), edge_alloc_(alloc)
+      : vertices_(alloc), edge_alloc_(alloc), graph_value_(gv)
 // clang-format on
 {
   // Handle empty case - no vertices or edges to create
@@ -1356,7 +1356,7 @@ template <typename VV,
           typename Alloc>
 undirected_adjacency_list<VV, EV, GV, VId, VContainer, Alloc>::undirected_adjacency_list(
       const initializer_list<tuple<vertex_key_type, vertex_key_type, edge_value_type>>& ilist, const Alloc& alloc)
-      : base_type(), vertices_(alloc), edge_alloc_(alloc) {
+      : vertices_(alloc), edge_alloc_(alloc) {
   // Evaluate max vertex key needed
   vertex_key_type max_vtx_key = vertex_key_type();
   for (auto& edge_data : ilist) {
@@ -1389,7 +1389,7 @@ template <typename VV,
           typename Alloc>
 undirected_adjacency_list<VV, EV, GV, VId, VContainer, Alloc>::undirected_adjacency_list(
       const initializer_list<tuple<vertex_key_type, vertex_key_type>>& ilist, const Alloc& alloc)
-      : base_type(), vertices_(alloc), edge_alloc_(alloc) {
+      : vertices_(alloc), edge_alloc_(alloc) {
   // Evaluate max vertex key needed
   vertex_key_type max_vtx_key = vertex_key_type();
   for (auto& edge_data : ilist) {
@@ -1423,8 +1423,8 @@ template <typename VV,
           typename Alloc>
 undirected_adjacency_list<VV, EV, GV, VId, VContainer, Alloc>::undirected_adjacency_list(
       const undirected_adjacency_list& other)
-      : base_type(static_cast<const base_type&>(other))
-      , edge_alloc_(other.edge_alloc_) {
+      : edge_alloc_(other.edge_alloc_)
+      , graph_value_(other.graph_value_) {
   // Reserve space and copy vertices (with empty edge lists)
   vertices_.reserve(other.vertices_.size());
   
@@ -1435,12 +1435,9 @@ undirected_adjacency_list<VV, EV, GV, VId, VContainer, Alloc>::undirected_adjace
     ++loop_count;
     if constexpr (std::is_void_v<VV>) {
       vertices_.emplace_back();
-    } else if constexpr (detail::graph_value_needs_wrap<VV>::value) {
-      // VV is a scalar/array/union/reference type - use graph_value_wrapper's .value member
-      vertices_.emplace_back(vertices_, static_cast<vertex_key_type>(vertices_.size()), 
-                             static_cast<const typename vertex_type::base_type&>(v).value);
     } else {
-      vertices_.emplace_back(vertices_, static_cast<vertex_key_type>(vertices_.size()), static_cast<const VV&>(v));
+      // Access vertex value member directly
+      vertices_.emplace_back(vertices_, static_cast<vertex_key_type>(vertices_.size()), v.value);
     }
   }
   
@@ -1455,11 +1452,9 @@ undirected_adjacency_list<VV, EV, GV, VId, VContainer, Alloc>::undirected_adjace
       if (ukey == src_key && src_key <= tgt_key) {
         if constexpr (std::is_void_v<EV>) {
           create_edge(src_key, tgt_key);
-        } else if constexpr (detail::graph_value_needs_wrap<EV>::value) {
-          // EV is a scalar/array/union/reference type - use graph_value_wrapper's .value member
-          create_edge(src_key, tgt_key, static_cast<const typename edge_type::base_type&>(*uv).value);
         } else {
-          create_edge(src_key, tgt_key, static_cast<const EV&>(*uv));
+          // Access edge value member directly
+          create_edge(src_key, tgt_key, uv->value);
         }
       }
     }
@@ -1863,7 +1858,7 @@ template <typename VV,
           typename Alloc>
 void undirected_adjacency_list<VV, EV, GV, VId, VContainer, Alloc>::swap(undirected_adjacency_list& rhs) {
   using std::swap;
-  swap(static_cast<base_type&>(*this), static_cast<base_type&>(rhs));
+  swap(graph_value_, rhs.graph_value_);
   vertices_.swap(rhs.vertices_);
   swap(edges_size_, rhs.edges_size_);
   swap(edge_alloc_, rhs.edge_alloc_);
diff --git a/include/graph/container/undirected_adjacency_list.hpp b/include/graph/container/undirected_adjacency_list.hpp
