Skip to content

Commit a34e2a9

Browse files
authored
Merge pull request kristerkari#34 from kristerkari/feat/deps-update
Update dependencies and fix Node11 sorting bug
2 parents 13ba6c9 + c1dc0d9 commit a34e2a9

File tree

8 files changed

+1775
-1701
lines changed

8 files changed

+1775
-1701
lines changed

.babelrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"presets": ["es2015"]
2+
"presets": ["@babel/preset-env"]
33
}

.travis.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,19 @@ cache:
88
- node_modules
99
matrix:
1010
include:
11-
- node_js: '9'
11+
- node_js: "11"
1212
script: npm test
13-
env: CI=test 9
14-
- node_js: '9'
13+
env: CI=test 11
14+
- node_js: "10"
15+
script: npm test
16+
env: CI=test 10
17+
- node_js: "10"
1518
script: npm test -- --runInBand --coverage
1619
env: CI=coverage
17-
- node_js: '8'
20+
- node_js: "8"
1821
script: npm test
1922
env: CI=test
20-
- node_js: '6'
23+
- node_js: "6"
2124
script: npm test
2225
env: CI=tests 6
2326
before_install:

appveyor.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
environment:
44
matrix:
5+
- nodejs_version: 11
6+
- nodejs_version: 10
7+
- nodejs_version: 8
58
- nodejs_version: 6
69

710
version: "{build}"

package.json

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,21 @@
99
"prettify": "prettier --write '**/*.@(js|json|md)'",
1010
"precommit": "lint-staged",
1111
"build": "babel src --ignore *.spec.js --out-dir dist",
12-
"test": "jest",
12+
"test": "jest --coverage",
1313
"prepublish": "npm run build",
1414
"release": "npmpub"
1515
},
1616
"devDependencies": {
17-
"babel-cli": "^6.26.0",
18-
"babel-core": "^6.26.3",
19-
"babel-jest": "^23.6.0",
20-
"babel-preset-es2015": "^6.24.1",
17+
"@babel/cli": "^7.2.3",
18+
"@babel/core": "^7.3.3",
19+
"@babel/preset-env": "^7.3.1",
20+
"babel-jest": "^24.1.0",
2121
"coveralls": "^3.0.2",
22-
"husky": "^1.1.4",
23-
"jest": "^23.6.0",
24-
"lint-staged": "^8.0.5",
22+
"husky": "^1.3.1",
23+
"jest": "^24.1.0",
24+
"lint-staged": "^8.1.4",
2525
"npmpub": "^4.1.0",
26-
"prettier": "^1.15.2"
26+
"prettier": "^1.16.4"
2727
},
2828
"jest": {
2929
"transform": {
@@ -41,7 +41,11 @@
4141
"lines": 75,
4242
"statements": 75
4343
}
44-
}
44+
},
45+
"testPathIgnorePatterns": [
46+
"<rootDir>/dist",
47+
"<rootDir>/node_modules"
48+
]
4549
},
4650
"lint-staged": {
4751
"*.{js,json,md}": [
@@ -55,7 +59,7 @@
5559
"dependencies": {
5660
"css": "^2.2.4",
5761
"css-mediaquery": "^0.1.2",
58-
"css-to-react-native": "^2.2.2"
62+
"css-to-react-native": "^2.3.0"
5963
},
6064
"repository": {
6165
"type": "git",

src/index.spec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1687,7 +1687,7 @@ describe("flex-box", () => {
16871687
}
16881688
`),
16891689
).toEqual({
1690-
test: { flexGrow: 0, flexShrink: 1 },
1690+
test: { flexBasis: "auto", flexGrow: 0, flexShrink: 1 },
16911691
});
16921692
});
16931693

@@ -1699,7 +1699,7 @@ describe("flex-box", () => {
16991699
}
17001700
`),
17011701
).toEqual({
1702-
test: { flexGrow: 0, flexShrink: 1 },
1702+
test: { flexBasis: "auto", flexGrow: 0, flexShrink: 1 },
17031703
});
17041704
});
17051705

@@ -1711,7 +1711,7 @@ describe("flex-box", () => {
17111711
}
17121712
`),
17131713
).toEqual({
1714-
test: { flexGrow: 1, flexShrink: 1 },
1714+
test: { flexBasis: "auto", flexGrow: 1, flexShrink: 1 },
17151715
});
17161716
});
17171717

@@ -1723,7 +1723,7 @@ describe("flex-box", () => {
17231723
}
17241724
`),
17251725
).toEqual({
1726-
test: { flexGrow: 0, flexShrink: 0 },
1726+
test: { flexBasis: "auto", flexGrow: 0, flexShrink: 0 },
17271727
});
17281728
});
17291729

src/utils/sortRules.js

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,23 @@ function isExport(n) {
33
}
44

55
function byExport(a, b) {
6-
return isExport(a.selectors);
6+
if (!isExport(a.selectors) && isExport(b.selectors)) {
7+
return -1;
8+
}
9+
if (isExport(a.selectors) && !isExport(b.selectors)) {
10+
return 1;
11+
}
12+
return 0;
713
}
814

915
function byLine(a, b) {
10-
if (
11-
isExport(a.selectors) &&
12-
isExport(b.selectors) &&
13-
a.position.start.line > b.position.start.line
14-
) {
15-
return 1;
16+
if (isExport(a.selectors) && isExport(b.selectors)) {
17+
if (a.position.start.line > b.position.start.line) {
18+
return 1;
19+
}
20+
if (a.position.start.line < b.position.start.line) {
21+
return -1;
22+
}
1623
}
1724
return 0;
1825
}

src/utils/sortRules.spec.js

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -215,16 +215,25 @@ describe("sortRules", () => {
215215
{
216216
type: "declaration",
217217
property: "bar",
218-
value: "3",
218+
value: "1",
219219
position: {
220-
start: { line: 3, column: 3 },
221-
end: { line: 3, column: 9 },
220+
start: { line: 11, column: 3 },
221+
end: { line: 11, column: 9 },
222+
},
223+
},
224+
{
225+
type: "declaration",
226+
property: "bar",
227+
value: "2",
228+
position: {
229+
start: { line: 12, column: 3 },
230+
end: { line: 12, column: 9 },
222231
},
223232
},
224233
],
225234
position: {
226-
start: { line: 2, column: 1 },
227-
end: { line: 4, column: 2 },
235+
start: { line: 10, column: 1 },
236+
end: { line: 13, column: 2 },
228237
},
229238
},
230239
{
@@ -253,25 +262,16 @@ describe("sortRules", () => {
253262
{
254263
type: "declaration",
255264
property: "bar",
256-
value: "1",
257-
position: {
258-
start: { line: 11, column: 3 },
259-
end: { line: 11, column: 9 },
260-
},
261-
},
262-
{
263-
type: "declaration",
264-
property: "bar",
265-
value: "2",
265+
value: "3",
266266
position: {
267-
start: { line: 12, column: 3 },
268-
end: { line: 12, column: 9 },
267+
start: { line: 3, column: 3 },
268+
end: { line: 3, column: 9 },
269269
},
270270
},
271271
],
272272
position: {
273-
start: { line: 10, column: 1 },
274-
end: { line: 13, column: 2 },
273+
start: { line: 2, column: 1 },
274+
end: { line: 4, column: 2 },
275275
},
276276
},
277277
]),

0 commit comments

Comments
 (0)