Merge pull request #1142 from stan-dev/fix-1140-add-missing-arguments

add show_messages and show_exceptions to generate_quantities

Author: jgabry

R/model.R

@@ -2001,12 +2001,16 @@ generate_quantities <- function(fitted_params,
                                 sig_figs = NULL,
                                 parallel_chains = getOption("mc.cores", 1),
                                 threads_per_chain = NULL,
-                                opencl_ids = NULL) {
+                                opencl_ids = NULL,
+                                show_messages = TRUE,
+                                show_exceptions = TRUE) {
   fitted_params_files <- process_fitted_params(fitted_params)
   procs <- CmdStanGQProcs$new(
     num_procs = length(fitted_params_files),
     parallel_procs = checkmate::assert_integerish(parallel_chains, lower = 1, null.ok = TRUE),
-    threads_per_proc = assert_valid_threads(threads_per_chain, self$cpp_options(), multiple_chains = TRUE)
+    threads_per_proc = assert_valid_threads(threads_per_chain, self$cpp_options(), multiple_chains = TRUE),
+    show_stderr_messages = show_exceptions,
+    show_stdout_messages = show_messages
   )
   model_variables <- NULL
   if (is_variables_method_supported(self)) {

man/model-method-generate-quantities.Rd

@@ -92,3 +92,14 @@ test_that("generate_quantities() warns if threads specified but not enabled", {
     "'threads_per_chain' will have no effect"
   )
 })
+
+test_that("no output with show_messages = FALSE", {
+  output <- utils::capture.output(
+    fit_gq <- mod_gq$generate_quantities(
+      fitted_params = fit,
+      data = data_list,
+      show_messages = FALSE
+    )
+  )
+  expect_equal(length(output), 0)
+})

tests/testthat/test-model-generate_quantities.R

@@ -150,3 +150,10 @@ test_that("no error when checking estimates after failure", {
   expect_silent(fit$summary()) # no error
 })
 
+test_that("no output with show_messages = FALSE", {
+  output <- utils::capture.output(
+    fit <- mod$pathfinder(data = data_list, show_messages = FALSE, seed = 123)
+  )
+  expect_equal(length(output), 0)
+})
+