fix: CTE table references now correctly modify AST for downstream resolution

The CTE implementation was storing an indirect but not modifying the
original AST node. This caused GetHIDs to still see a TableName type
instead of a Subquery type, resulting in "could not locate table" errors.

Fix: Modify the original node.Expr to be the CTE's Subquery instead of
creating a synthetic expression. This ensures downstream code correctly
recognizes the CTE reference as a subquery.

Also re-enables the CTE robot test.

Author: claude

internal/stackql/astanalysis/earlyanalysis/ast_expand.go

@@ -190,22 +190,19 @@ func (v *indirectExpandAstVisitor) processCTEReference(
 	if !isCTE {
 		return false
 	}
-	// Use the CTE name as the effective alias if no explicit alias is set
-	effectiveAlias := node.As.GetRawVal()
-	if effectiveAlias == "" {
-		effectiveAlias = tableName
+	// Modify the original node to replace the TableName with the CTE subquery
+	// This is critical: downstream code (GetHIDs) checks node.Expr type to identify subqueries
+	node.Expr = cteSubquery
+	// Set the alias to the CTE name if no explicit alias was provided
+	if node.As.IsEmpty() {
+		node.As = sqlparser.NewTableIdent(tableName)
 	}
-	// Create a synthetic AliasedTableExpr with the CTE subquery
-	syntheticExpr := &sqlparser.AliasedTableExpr{
-		Expr: cteSubquery,
-		As:   sqlparser.NewTableIdent(effectiveAlias),
-	}
-	sq := internaldto.NewSubqueryDTO(syntheticExpr, cteSubquery)
+	sq := internaldto.NewSubqueryDTO(node, cteSubquery)
 	indirect, err := astindirect.NewSubqueryIndirect(sq)
 	if err != nil {
 		return true //nolint:nilerr //TODO: investigate
 	}
-	_ = v.processIndirect(syntheticExpr, indirect) //nolint:errcheck // errors handled via indirect pattern
+	_ = v.processIndirect(node, indirect) //nolint:errcheck // errors handled via indirect pattern
 	return true
 }
 

test/robot/functional/stackql_mocked_from_cmd_line.robot

@@ -152,18 +152,17 @@ Window Function RANK Over AcceleratorTypes
     ...    ${SELECT_ACCELERATOR_TYPES_RANK}
     ...    ${SELECT_ACCELERATOR_TYPES_RANK_EXPECTED}
 
-# CTE test temporarily disabled for debugging - CTE support may need more work
-# CTE Simple Select Over AcceleratorTypes
-#     Should StackQL Exec Inline Equal
-#     ...    ${STACKQL_EXE}
-#     ...    ${OKTA_SECRET_STR}
-#     ...    ${GITHUB_SECRET_STR}
-#     ...    ${K8S_SECRET_STR}
-#     ...    ${REGISTRY_NO_VERIFY_CFG_STR}
-#     ...    ${AUTH_CFG_STR}
-#     ...    ${SQL_BACKEND_CFG_STR_CANONICAL}
-#     ...    ${SELECT_ACCELERATOR_TYPES_SIMPLE_CTE}
-#     ...    ${SELECT_ACCELERATOR_TYPES_SIMPLE_CTE_EXPECTED}
+CTE Simple Select Over AcceleratorTypes
+    Should StackQL Exec Inline Equal
+    ...    ${STACKQL_EXE}
+    ...    ${OKTA_SECRET_STR}
+    ...    ${GITHUB_SECRET_STR}
+    ...    ${K8S_SECRET_STR}
+    ...    ${REGISTRY_NO_VERIFY_CFG_STR}
+    ...    ${AUTH_CFG_STR}
+    ...    ${SQL_BACKEND_CFG_STR_CANONICAL}
+    ...    ${SELECT_ACCELERATOR_TYPES_SIMPLE_CTE}
+    ...    ${SELECT_ACCELERATOR_TYPES_SIMPLE_CTE_EXPECTED}
 
 Google Machine Types Select Paginated
     Should Horrid Query StackQL Inline Equal