Remove duplicate SetBuilder call that caused cyclic primitive graph

claude · claude · commit 79df09d23181 · 2025-12-03T08:46:51.000Z
diff --git a/internal/stackql/primitivegenerator/select.go b/internal/stackql/primitivegenerator/select.go
@@ -224,11 +224,6 @@ func (pb *standardPrimitiveGenerator) analyzeSelect(pbi planbuilderinput.PlanBui
 			selCtx := dp.GetSelectCtx()
 			pChild.GetPrimitiveComposer().SetBuilder(bld)
 			pb.PrimitiveComposer.SetSelectPreparedStatementCtx(selCtx)
-			// For indirects (subqueries, views, etc.), also set the builder on the indirect's
-			// primitive composer so it can be found when parent's GetBuilder() iterates.
-			if pb.PrimitiveComposer.IsIndirect() {
-				pb.PrimitiveComposer.SetBuilder(bld)
-			}
 			return nil
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -224,11 +224,6 @@ func (pb *standardPrimitiveGenerator) analyzeSelect(pbi planbuilderinput.PlanBui`
`224`	`224`	`selCtx := dp.GetSelectCtx()`
`225`	`225`	`pChild.GetPrimitiveComposer().SetBuilder(bld)`
`226`	`226`	`pb.PrimitiveComposer.SetSelectPreparedStatementCtx(selCtx)`
`227`		`- // For indirects (subqueries, views, etc.), also set the builder on the indirect's`
`228`		`- // primitive composer so it can be found when parent's GetBuilder() iterates.`
`229`		`- if pb.PrimitiveComposer.IsIndirect() {`
`230`		`- pb.PrimitiveComposer.SetBuilder(bld)`
`231`		`- }`
`232`	`227`	`return nil`
`233`	`228`	`}`
`234`	`229`	`}`