Merge pull request #114 from stackql/claude/fix-window-function-execution-01WbDt4A6kMPzL5KJmLWAHBU

Claude/fix window function execution 01 wb dt4 a6k m pz l5 k jm lwahbu

Author: jeffreyaven

internal/stackql/astvisit/fragment_rewriting.go

@@ -905,6 +905,9 @@ func (v *standardFragmentRewriteAstVisitor) Visit(node sqlparser.SQLNode) error
 			buf.WriteString(funcName)
 		}
 		buf.AstPrintf(node, "(%s%v)", distinct, node.Exprs)
+		if node.Over != nil {
+			buf.AstPrintf(node, " %v", node.Over)
+		}
 		v.rewrittenQuery = buf.String()
 
 	case *sqlparser.GroupConcatExpr:

internal/stackql/astvisit/from_rewrite.go

@@ -975,6 +975,9 @@ func (v *standardFromRewriteAstVisitor) Visit(node sqlparser.SQLNode) error {
 			buf.WriteString(funcName)
 		}
 		buf.AstPrintf(node, "(%s%v)", distinct, node.Exprs)
+		if node.Over != nil {
+			buf.AstPrintf(node, " %v", node.Over)
+		}
 		v.rewrittenQuery = buf.String()
 
 	case *sqlparser.GroupConcatExpr:

internal/stackql/astvisit/provider_string_extract.go

@@ -904,6 +904,9 @@ func (v *standardProviderStringAstVisitor) Visit(node sqlparser.SQLNode) error {
 			buf.WriteString(funcName)
 		}
 		buf.AstPrintf(node, "(%s%v)", distinct, node.Exprs)
+		if node.Over != nil {
+			buf.AstPrintf(node, " %v", node.Over)
+		}
 		// v.rewrittenQuery = buf.String()
 
 	case *sqlparser.GroupConcatExpr:

internal/stackql/parserutil/parser_util.go

@@ -676,7 +676,14 @@ func inferColNameFromExpr(
 					exprsDecorated = append(exprsDecorated, rv.DecoratedColumn)
 				}
 			}
-			decoratedColumn := fmt.Sprintf("%s(%s)", funcNameLowered, strings.Join(exprsDecorated, ", "))
+			// Use astformat.String for window functions to include OVER clause,
+			// otherwise use the manually constructed decorated column for proper arg handling
+			var decoratedColumn string
+			if expr.Over != nil {
+				decoratedColumn = astformat.String(expr, formatter)
+			} else {
+				decoratedColumn = fmt.Sprintf("%s(%s)", funcNameLowered, strings.Join(exprsDecorated, ", "))
+			}
 			if retVal.Name != constants.SQLFuncJSONExtractPostgres {
 				retVal.DecoratedColumn = getDecoratedColRendition(decoratedColumn, alias)
 			}