fix(provenant): address warning-level code quality issues

- Add console.warn to silent catch blocks in ingest.ts and engine.ts
- Sanitize error messages in query fallback to prevent API key leakage
- Fix reasoning_resolved type from boolean to 0|1 to match SQLite storage
- Remove unnecessary Promise.resolve wrapper in keywordSearch

Author: StackMemory Bot (CLI)

packages/provenant/src/pipeline/ingest.ts

@@ -113,8 +113,11 @@ export async function ingest(
       let dedupResult: DedupResult;
       try {
         dedupResult = await checkDedup(db, embedder, record, cfg);
-      } catch {
-        // Embedding failed — skip dedup, treat as independent
+      } catch (err) {
+        console.warn(
+          '[provenant] dedup check failed, treating as independent:',
+          err
+        );
         dedupResult = { outcome: 'independent' };
       }
       if (dedupResult.outcome === 'merged') {
@@ -152,8 +155,11 @@ export async function ingest(
           embedding = embeddingToBuffer(
             (await embedder.embed(record.content)).embedding
           );
-        } catch {
-          // Embedding failed — write node without embedding
+        } catch (err) {
+          console.warn(
+            '[provenant] embedding failed, writing node without embedding:',
+            err
+          );
         }
       }
 

packages/provenant/src/query/engine.ts

@@ -92,8 +92,12 @@ export async function query(
     answer = await askClaude(question, context, config);
   } catch (err) {
     // LLM unavailable — return raw context as the answer
-    const msg = err instanceof Error ? err.message : String(err);
-    answer = `[Claude unavailable: ${msg}]\n\nRaw context:\n${context}`;
+    const msg = err instanceof Error ? err.message : 'unknown error';
+    // Sanitize error message to avoid leaking API keys in auth errors
+    const safeMsg = msg
+      .replace(/sk-[a-zA-Z0-9-_]+/g, '[REDACTED]')
+      .replace(/key[_-]?[a-zA-Z0-9]{16,}/gi, '[REDACTED]');
+    answer = `[Claude unavailable: ${safeMsg}]\n\nRaw context:\n${context}`;
   }
 
   return {
@@ -118,8 +122,11 @@ async function findRelevantNodes(
   if (embedder) {
     try {
       return await semanticSearch(db, embedder, question, maxNodes, config);
-    } catch {
-      // Embedding failed (bad key, network, etc.) — fall back to keywords
+    } catch (err) {
+      console.warn(
+        '[provenant] semantic search failed, falling back to keywords:',
+        err
+      );
     }
   }
   return keywordSearch(db, question, maxNodes, config);
@@ -152,7 +159,7 @@ function keywordSearch(
   question: string,
   maxNodes: number,
   config: QueryConfig
-): Promise<Citation[]> {
+): Citation[] {
   // Extract keywords (strip common words)
   const stopwords = new Set([
     'the',
@@ -197,14 +204,12 @@ function keywordSearch(
     config.since
   );
 
-  return Promise.resolve(
-    nodes.map((node) => ({
-      node,
-      sources: [],
-      edges: [],
-      relevance: 0.5, // unknown relevance without embeddings
-    }))
-  );
+  return nodes.map((node) => ({
+    node,
+    sources: [],
+    edges: [],
+    relevance: 0.5, // unknown relevance without embeddings
+  }));
 }
 
 // --- Context building ---

packages/provenant/src/schema/database.ts

@@ -352,7 +352,7 @@ export class Database {
       suggestion_node: params.suggestion_node,
       override_node: params.override_node ?? null,
       reasoning: params.reasoning ?? null,
-      reasoning_resolved: params.reasoning != null,
+      reasoning_resolved: params.reasoning != null ? 1 : 0,
       actor: params.actor ?? null,
       created_at: Date.now(),
     };

packages/provenant/src/schema/types.ts

@@ -67,7 +67,7 @@ export interface RejectionLogEntry {
   suggestion_node: string;
   override_node: string | null;
   reasoning: string | null;
-  reasoning_resolved: boolean;
+  reasoning_resolved: 0 | 1;
   actor: string | null;
   created_at: number;
 }