adapted volume snapshots list command to align to expectations

Author: j1n-o9r

internal/cmd/volume/snapshot/list/list.go

@@ -72,25 +72,20 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
 				return fmt.Errorf("list snapshots: %w", err)
 			}
 
-			// Check if response is empty
-			if resp.Items == nil || len(*resp.Items) == 0 {
-				projectLabel, err := projectname.GetProjectName(ctx, params.Printer, params.CliVersion, cmd)
-				if err != nil {
-					params.Printer.Debug(print.ErrorLevel, "get project name: %v", err)
-					projectLabel = model.ProjectId
-				}
-				params.Printer.Info("No snapshots found for project %q\n", projectLabel)
-				return nil
-			}
+			snapshots := resp.GetItems()
 
-			snapshots := *resp.Items
+			projectLabel, err := projectname.GetProjectName(ctx, params.Printer, params.CliVersion, cmd)
+			if err != nil {
+				params.Printer.Debug(print.ErrorLevel, "get project name: %v", err)
+				projectLabel = model.ProjectId
+			}
 
-			// Apply limit if specified
+			// Truncate output
 			if model.Limit != nil && int(*model.Limit) < len(snapshots) {
 				snapshots = snapshots[:*model.Limit]
 			}
 
-			return outputResult(params.Printer, model.OutputFormat, snapshots)
+			return outputResult(params.Printer, model.OutputFormat, projectLabel, snapshots)
 		},
 	}
 
@@ -137,12 +132,12 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APICli
 	return req
 }
 
-func outputResult(p *print.Printer, outputFormat string, snapshots []iaas.Snapshot) error {
-	if snapshots == nil {
-		return fmt.Errorf("list snapshots response is empty")
-	}
-
+func outputResult(p *print.Printer, outputFormat, projectLabel string, snapshots []iaas.Snapshot) error {
 	return p.OutputResult(outputFormat, snapshots, func() error {
+		if len(snapshots) == 0 {
+			p.Outputf("No snapshots found for project %q\n", projectLabel)
+			return nil
+		}
 		table := tables.NewTable()
 		table.SetHeader("ID", "NAME", "SIZE", "STATUS", "VOLUME ID", "LABELS", "CREATED AT", "UPDATED AT")
 

internal/cmd/volume/snapshot/list/list_test.go

@@ -183,6 +183,7 @@ func TestBuildRequest(t *testing.T) {
 func TestOutputResult(t *testing.T) {
 	type args struct {
 		outputFormat string
+		projectLabel string
 		snapshots    []iaas.Snapshot
 	}
 	tests := []struct {
@@ -193,7 +194,7 @@ func TestOutputResult(t *testing.T) {
 		{
 			name:    "empty",
 			args:    args{},
-			wantErr: true,
+			wantErr: false,
 		},
 		{
 			name: "empty snapshot in slice",
@@ -221,7 +222,7 @@ func TestOutputResult(t *testing.T) {
 	p.Cmd = NewCmd(&types.CmdParams{Printer: p})
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			if err := outputResult(p, tt.args.outputFormat, tt.args.snapshots); (err != nil) != tt.wantErr {
+			if err := outputResult(p, tt.args.outputFormat, tt.args.projectLabel, tt.args.snapshots); (err != nil) != tt.wantErr {
 				t.Errorf("outputResult() error = %v, wantErr %v", err, tt.wantErr)
 			}
 		})