Fix empty yum.repos.d in overcloud host image (#2041)

* Fix empty yum.repos.d in overcloud host image

no repos causes installation of tmux fail in terraform-kayobe-multinode.
This regression was introduced by commit e0d1d6d

* bump rocky9 overcloud host image

* fix comment in stackhpc-overcloud-dib.yml

following review

Co-authored-by: Alex Welsh <112560678+Alex-Welsh@users.noreply.github.com>

* Add release note restore-rocky-repos

---------

Co-authored-by: Alex Welsh <112560678+Alex-Welsh@users.noreply.github.com>

Author: elelaysh

etc/kayobe/pulp-host-image-versions.yml

@@ -1,5 +1,5 @@
 ---
 # Overcloud host image versioning tags
 # These images must be in SMS, since they are used by our AIO CI runners
-stackhpc_rocky_9_overcloud_host_image_version: "2025.1-20251027T102633"
+stackhpc_rocky_9_overcloud_host_image_version: "2025.1-20251216T122459"
 stackhpc_ubuntu_noble_overcloud_host_image_version: "2025.1-20250930T144255"

etc/kayobe/stackhpc-overcloud-dib.yml

@@ -56,11 +56,15 @@ stackhpc_overcloud_dib_env_vars_default:
   # Workaround for stack user home ownership bug
   DIB_IMAGE_CACHE: "/tmp/yum"
 
+# NB: use --build-arg to pass arguments only to the Dockerfile.
+# Use stackhpc_overcloud_dib_env_vars_ark keys directly for elements (eg 80-cleanup-and-restore-repofiles)
 stackhpc_overcloud_dib_env_vars_ark:
   DIB_CONTAINERFILE_BUILDOPTS: >-
     --build-arg=ROCKY_USE_CUSTOM_DNF_MIRRORS=true
     --build-arg=ROCKY_CUSTOM_DNF_MIRROR_URLS={{ [stackhpc_repo_rocky_9_baseos_url, stackhpc_repo_rocky_9_appstream_url] | join(',') }}
   DIB_DISTRIBUTION_MIRROR: "{{ stackhpc_repo_ubuntu_noble_url if os_distribution == 'ubuntu' else '' }}"
+  # Ensure upstream repofiles are re-enabled after image build, otherwise `yum.repos.d` is left empty
+  DIB_ROCKY_CONTAINER_STACKHPC_RESTORE_UPSTREAM_REPOFILES: true
 
 # StackHPC overcloud DIB image packages.
 stackhpc_overcloud_dib_packages:

releasenotes/notes/restore-rocky-repos-c33ee54809836851.yaml

@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    The default Rocky 9 overcloud host image has been updated to include
+    upstream package repos out of the box