Slideshow captures incorrect first frame when we immediately pause after recording starts

[ranwer-dev]

If we are doing a Slideshow recording and using Pause right after the recording starts, like

ScreenRecorder.Record(outputFile);
ScreenRecorder.Pause();

Then after resuming the recorder, we get the first frame which was captured before Pausing the recorder.

[sskodje]

Indeed it does, thanks 👍

[ranwer-dev]

I just noticed it's valid for screen recording as well

[ranwer-dev]

I tested the fix you pushed, which works well for the slideshow. However, the issue is still occasionally reproducible with videos.

[ranwer-dev]

The issue is still occasionally reproducible with screen recording

[sskodje]

Alright, i'll reopen it and have a look when i get the time

[ranwer-dev]

Would adding a startPaused param to the BeginRecording function and using it during setup be a better way to handle this? It seems to be working abnormally in some cases.

HRESULT RecordingManager::BeginRecording(_In_opt_ std::wstring path, _In_opt_ IStream *stream, **bool startPaused = false**) {
	if (m_IsRecording) {
		if (m_IsPaused) {
			ResumeRecording();
		}
		else {
			std::wstring error = L"Recording is already in progress, aborting";
			LOG_WARN("%ls", error.c_str());
			if (RecordingFailedCallback != nullptr)
				RecordingFailedCallback(error, L"");
		}
		return S_FALSE;
	}
	wstring errorText;
	if (!CheckDependencies(&errorText)) {
		LOG_ERROR(L"%ls", errorText);
		if (RecordingFailedCallback != nullptr)
			RecordingFailedCallback(errorText, L"");
		return S_FALSE;
	}
	m_EncoderResult = S_FALSE;
	RETURN_ON_BAD_HR(ConfigureOutputDir(path));

	if (m_RecordingSources.size() == 0) {
		std::wstring error = L"No valid recording sources found in recorder parameters.";
		LOG_ERROR("%ls", error.c_str());
		if (RecordingFailedCallback != nullptr)
			RecordingFailedCallback(error, L"");
		return S_FALSE;
	}
	m_IsRecording = true;
	**m_IsPaused = startPaused;**
	
	m_TaskWrapperImpl->m_RecordTaskCts = cancellation_token_source();
	m_TaskWrapperImpl->m_RecordTask = concurrency::create_task([this, stream, **startPaused**]() {
		LOG_INFO(L"Starting recording task");
		REC_RESULT result{};
		HRESULT hr = CoInitializeEx(nullptr, COINITBASE_MULTITHREADED | COINIT_DISABLE_OLE1DDE);
		RETURN_RESULT_ON_BAD_HR(hr, L"CoInitializeEx failed");
		RETURN_RESULT_ON_BAD_HR(hr = InitializeDx(nullptr, &m_DxResources), L"Failed to initialize DirectX");

		m_TextureManager = make_unique<TextureManager>();
		RETURN_RESULT_ON_BAD_HR(hr = m_TextureManager->Initialize(m_DxResources.Context, m_DxResources.Device), L"Failed to initialize TextureManager");
		
		m_OutputManager = make_unique<OutputManager>();
		RETURN_RESULT_ON_BAD_HR(hr = m_OutputManager->Initialize(m_DxResources.Context, m_DxResources.Device, GetEncoderOptions(), GetAudioOptions(), GetSnapshotOptions(), GetOutputOptions()), L"Failed to initialize OutputManager");
		
		// Pause media clock immediately after initialization if starting paused
		**if (startPaused) {
			m_OutputManager->PauseMediaClock();
			LOG_DEBUG("Paused media clock after initialization");
		}**
		
		m_CaptureManager = make_unique<ScreenCaptureManager>();
		RETURN_RESULT_ON_BAD_HR(m_CaptureManager->Initialize(m_DxResources.Context, m_DxResources.Device, GetOutputOptions(), GetEncoderOptions(), GetMouseOptions()), L"Failed to initialize ScreenCaptureManager");
		m_MouseManager = make_unique<MouseManager>();
		RETURN_RESULT_ON_BAD_HR(hr = m_MouseManager->Initialize(m_DxResources.Context, m_DxResources.Device, GetMouseOptions()), L"Failed to initialize mouse manager");

		result = StartRecorderLoop(m_RecordingSources, m_Overlays, stream);
		if (RecordingStatusChangedCallback != nullptr && !m_IsDestructing) {
			RecordingStatusChangedCallback(STATUS_FINALIZING);
		}
		result.FinalizeResult = m_OutputManager->FinalizeRecording();
		CoUninitialize();

		LOG_INFO("Exiting recording task");
		return result;
		}).then([this](concurrency::task<REC_RESULT> t)
				{
					m_CaptureManager.reset(nullptr);
					m_MouseManager.reset(nullptr);
					m_IsRecording = false;
					m_IsPaused = false;
					REC_RESULT result{ };
					try {
						result = t.get();
						// if .get() didn't throw and the HRESULT succeeded, there are no errors.
					}
					catch (...) {
						LOG_ERROR(L"Exception in RecordTask");
					}
					CleanupDxResources();
					if (!m_IsDestructing) {
						nlohmann::fifo_map<std::wstring, int> delays{};
						if (m_OutputManager) {
							delays = m_OutputManager->GetFrameDelays();
						}
						SetRecordingCompleteStatus(result, delays);
					}
				});
	
	// Send appropriate initial status
	if (RecordingStatusChangedCallback != nullptr) {
		**if (startPaused) {
			RecordingStatusChangedCallback(STATUS_PAUSED);
			LOG_DEBUG("Changed Recording Status to Paused");
		}**
	}
	
	return S_OK;
}

[sskodje]

I'm not able to reproduce any this behavior. Do you have any logs of this happening, or reproducable sample code? I don't like to make any potential breaking changes blind :)