fix macOS junk file cleanup (rewrite in Python)

Old shell script was broken — find -exec can't call shell functions,
so nothing was actually deleted. Rewrote as Python with the shell
script as a thin wrapper. Also adds __MACOSX and .apdisk to the
junk list.

Author: Sundownersport

spruce/scripts/tasks/deleteMacFiles.py

@@ -0,0 +1,69 @@
+#!/usr/bin/env python3
+"""Delete macOS junk files from the SD card."""
+
+import os
+import shutil
+
+SDCARD = "/mnt/SDCARD"
+
+JUNK_NAMES = {
+    ".DS_Store",
+    ".DocumentRevisions-V100",
+    ".Spotlight-V100",
+    ".TemporaryItems",
+    ".Trashes",
+    ".fseventsd",
+    ".VolumeIcon.icns",
+    "__MACOSX",
+    ".apdisk",
+}
+
+# AppleDouble magic bytes: 00 05 16 07
+APPLE_DOUBLE_MAGIC = b"\x00\x05\x16\x07"
+
+
+def is_apple_double(path):
+    """Check if a file has the AppleDouble header."""
+    try:
+        with open(path, "rb") as f:
+            return f.read(4) == APPLE_DOUBLE_MAGIC
+    except (OSError, IOError):
+        return False
+
+
+def should_delete(name, path):
+    if name in JUNK_NAMES:
+        return True
+    if name.startswith("._"):
+        return True
+    if os.path.isfile(path) and is_apple_double(path):
+        return True
+    return False
+
+
+def clean(root):
+    deleted = 0
+    for dirpath, dirnames, filenames in os.walk(root, topdown=True):
+        # Check directories (iterate copy since we may modify dirnames)
+        for d in list(dirnames):
+            full = os.path.join(dirpath, d)
+            if should_delete(d, full):
+                shutil.rmtree(full, ignore_errors=True)
+                dirnames.remove(d)
+                deleted += 1
+
+        for f in filenames:
+            full = os.path.join(dirpath, f)
+            if should_delete(f, full):
+                try:
+                    os.remove(full)
+                except OSError:
+                    pass
+                deleted += 1
+
+    return deleted
+
+
+if __name__ == "__main__":
+    count = clean(SDCARD)
+    print(f"Deleted {count} macOS junk file(s).")

spruce/scripts/tasks/deleteMacFiles.sh

@@ -1,27 +1,5 @@
 #!/bin/sh
 
-check_and_delete() {
-    BASENAME="$(basename "$1")"
-    if [ "$BASENAME" = ".DS_Store" ] || \
-         [ "$BASENAME" = ".DocumentRevisions-V100" ] || \
-         [ "$BASENAME" = ".Spotlight-V100" ] || \
-         [ "$BASENAME" = ".TemporaryItems" ] || \
-         [ "$BASENAME" = ".Trashes" ] || \
-         [ "$BASENAME" = ".fseventsd" ] || \
-         [ "$BASENAME" = ".VolumeIcon.icns" ] || \
-         [ "$(xxd -p -g2 -c16 "$1" | head -n1)" = "00051607000200004d6163204f532058" ]; then
-            rm -rf "$1"
-    fi
-}
-
 log_message "Cleaning up macOS junk files..."
-find "/mnt/SDCARD" \( \
-    -name '._*' \
-    -or -name '*DS_Store' \
-    -or -name '.VolumeIcon.icns' \
-    -or -name '.fseventsd' \
-    -or -name '.Trashes' \
-    -or -name '.TemporaryItems' \
-    -or -name '.Spotlight-V100' \
-    -or -name '.DocumentRevisions-V100' \) \
-    -exec check_and_delete {} +
+result="$(python3 /mnt/SDCARD/spruce/scripts/tasks/deleteMacFiles.py)"
+log_message "$result"