Skip to content

Commit 701848e

Browse files
author
mihaita.tinta
committed
fix schemas
Signed-off-by: mihaita.tinta <mihaita.tinta@ing.com>
1 parent 7811d1e commit 701848e

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

spring-modulith-events/spring-modulith-events-jdbc/src/main/java/org/springframework/modulith/events/jdbc/JdbcEventPublicationRepository.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ class JdbcEventPublicationRepository implements EventPublicationRepository, Bean
8181
FROM %s e
8282
LEFT JOIN %s f on f.EVENT_ID = e.ID
8383
WHERE COMPLETION_DATE IS NULL
84-
ORDER BY PUBLICATION_DATE ASC
84+
ORDER BY e.PUBLICATION_DATE ASC, f.FAILED_DATE
8585
""";
8686

8787
private static final String SQL_STATEMENT_FIND_UNCOMPLETED_BEFORE = """
@@ -92,7 +92,7 @@ class JdbcEventPublicationRepository implements EventPublicationRepository, Bean
9292
WHERE
9393
e.COMPLETION_DATE IS NULL
9494
AND e.PUBLICATION_DATE < ?
95-
ORDER BY e.PUBLICATION_DATE ASC
95+
ORDER BY e.PUBLICATION_DATE ASC, f.FAILED_DATE
9696
""";
9797

9898
private static final String SQL_STATEMENT_UPDATE_BY_EVENT_AND_LISTENER_ID = """

spring-modulith-events/spring-modulith-events-jdbc/src/test/java/org/springframework/modulith/events/jdbc/JdbcEventPublicationRepositoryIntegrationTests.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -432,18 +432,19 @@ void findsPublicationsThatFailedOnce() {
432432
void findsPublicationsThatFailedTwice() {
433433

434434
var first = createPublication(new TestEvent("first"));
435-
Instant now = Instant.now();
435+
Instant firstTry = Instant.now().minusSeconds(10);
436+
Instant secondTry = Instant.now().minusSeconds(5);
436437
IllegalStateException reason1 = new IllegalStateException("failed once");
437438
IllegalStateException reason2 = new IllegalStateException("failed second time");
438-
var entry1 = new JdbcEventPublicationRepository.JdbcFailedAttemptInfo(now, reason1);
439-
var entry2 = new JdbcEventPublicationRepository.JdbcFailedAttemptInfo(now, reason2);
439+
var entry1 = new JdbcEventPublicationRepository.JdbcFailedAttemptInfo(firstTry, reason1);
440+
var entry2 = new JdbcEventPublicationRepository.JdbcFailedAttemptInfo(secondTry, reason2);
440441
doReturn(reason1.toString()).when(serializer).serialize(reason1);
441442
doReturn(reason2.toString()).when(serializer).serialize(reason2);
442443
doReturn(reason1).when(serializer).deserialize(reason1.toString(), reason1.getClass());
443444
doReturn(reason2).when(serializer).deserialize(reason2.toString(), reason2.getClass());
444445

445-
repository.markFailed(first.getIdentifier(), now, reason1);
446-
repository.markFailed(first.getIdentifier(), now, reason2);
446+
repository.markFailed(first.getIdentifier(), firstTry, reason1);
447+
repository.markFailed(first.getIdentifier(), secondTry, reason2);
447448

448449
assertThat(repository.findIncompletePublications())
449450
.extracting(TargetEventPublication::getFailedAttempts)

0 commit comments

Comments
 (0)