Commit 91b6beb
committed
Fix test failure only seen on CI
The failure was in GraphQlWebSocketHandlerTests for WebMvc.
the subscriptionExists test checks that a second subscription with
same id will close the connection with 4409. It also checks that
2 messages have arrived (connection_init) and one message from the
first subscription. However, since message handling as async,
handling of the two subscriptions is concurrent, and the connection
may be closed before the first subscription is able to send.
This commit adjusts the message checks to be more lenient and
accept between 1 and 2 messages.1 parent aa1ee77 commit 91b6beb
File tree
2 files changed
+4
-5
lines changed- spring-graphql/src/test/java/org/springframework/graphql/server
- webflux
- webmvc
2 files changed
+4
-5
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
288 | 288 | | |
289 | 289 | | |
290 | 290 | | |
| 291 | + | |
291 | 292 | | |
292 | | - | |
293 | 293 | | |
294 | 294 | | |
295 | 295 | | |
| |||
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
293 | 293 | | |
294 | 294 | | |
295 | 295 | | |
296 | | - | |
| 296 | + | |
297 | 297 | | |
298 | | - | |
299 | 298 | | |
300 | 299 | | |
301 | 300 | | |
| |||
0 commit comments