`HttpMethod.valueOf()` does not perform case-insensitive lookup

[wbrco]

Spent several hours troubleshooting 400 responses where lower case values were being parsed by HttpMethod.valueOf(). when used with WebClient.method().

Please either:

• Update the API documentation stating that the method doesn't normalize the value to uppercase.
• In the method, perform a .toUpperCase() before passing it to the switch statement.
• Or thow an IllegalArgumentException when a lower case string is passed.

Sometimes it's the little things that count!

Thank You!

[sbrannen]

HttpMethod was originally an enum, but it was converted to a Class in commit 6e335e3.

Consequently, the behavior of valueOf() is consistent with the behavior defined for Enum.valueOf() in the JDK.

However, I admit that the current Javadoc for HttpMethod.valueOf() is not clear in that regard. Thus we should at least improve the documentation.

In addition, I can understand the desire to have HttpMethod.valueOf() perform a case-insensitive lookup for predefined constants. So we'll discuss that within the team.

[angry-2k]

@sbrannen
Thank you for the clarification! I understand that improving the Javadoc is confirmed, while the case-insensitive lookup behavior is still under team discussion.

Would it be okay if I submitted a PR to improve the Javadoc for HttpMethod.valueOf() in the meantime?

[sbrannen]

Would it be okay if I submitted a PR to improve the Javadoc for HttpMethod.valueOf() in the meantime?

Thanks for the offer, but please hold off on submitting anything until the team has made a decision.

[wbrco]

First, I want to thank the team for all the attention this is receiving!

Wouldn't the fully defensive code be to uppercase(), and if there is no match, throw an IllegalArgurmentException?

Of course, I defer to any decision made by the team, as this would be a breaking change.