Extract duplicate duration validation logic to helper method #3273
+7
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #3269 by extracting duplicate duration validation logic into a reusable helper method.
Changes
isPositiveDuration(Duration)helper method to eliminate code duplicationsleepTimemethod)isLockingCacheWritermethod)Motivation
The same validation pattern
!duration.isZero() && !duration.isNegative()was duplicated in two locations, violating the DRY (Don't Repeat Yourself) principle. Extracting this into a helper method improves codemaintainability and readability.
Closes gh-3269
Checklist