Skip to content

Commit d49b113

Browse files
committed
Simplify test to not test things it does not do
Signed-off-by: Chris Bono <chris.bono@broadcom.com>
1 parent b8ca61d commit d49b113

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

src/test/java/org/springframework/data/redis/connection/jedis/StreamConvertersUnitTest.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import java.time.Duration;
2525
import java.time.temporal.ChronoUnit;
2626

27+
import org.assertj.core.api.InstanceOfAssertFactories;
2728
import org.junit.jupiter.api.Nested;
2829
import org.junit.jupiter.api.Test;
2930

@@ -125,18 +126,14 @@ void convertXAddOptionsWithDeletionPolicy() {
125126
@Test
126127
void convertXAddOptionsWithRecordId() {
127128

128-
RecordId recordId = RecordId.of("1234567890-0");
129+
String testId = "1234567890-0";
130+
RecordId recordId = RecordId.of(testId);
129131
XAddOptions options = XAddOptions.none();
130132

131133
XAddParams params = StreamConverters.toXAddParams(recordId, options);
132134

133-
assertThat(params).hasFieldOrPropertyWithValue("maxLen", null);
134-
assertThat(params).hasFieldOrPropertyWithValue("minId", null);
135-
assertThat(params).hasFieldOrPropertyWithValue("limit", null);
136-
assertThat(params).hasFieldOrPropertyWithValue("trimMode", null);
137-
assertThat(params).hasFieldOrPropertyWithValue("nomkstream", false);
138-
assertThat(params).hasFieldOrPropertyWithValue("exactTrimming", false);
139-
assertThat(params).hasFieldOrPropertyWithValue("approximateTrimming", false);
135+
assertThat(params).extracting("id.raw").asInstanceOf(InstanceOfAssertFactories.BYTE_ARRAY)
136+
.satisfies(idRawBytes -> assertThat(new String(idRawBytes)).isEqualTo(testId));
140137
}
141138
}
142139

0 commit comments

Comments
 (0)