Skip to content

Commit baf6824

Browse files
committed
Added author and test case for jedis topologyRefreshPeriod
1 parent 7ad1976 commit baf6824

4 files changed

Lines changed: 9 additions & 1 deletion

File tree

src/main/java/org/springframework/data/redis/connection/jedis/DefaultJedisClientConfiguration.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
*
3131
* @author Mark Paluch
3232
* @author Christoph Strobl
33+
* @author Bharat Agarwal
3334
* @since 2.0
3435
*/
3536
class DefaultJedisClientConfiguration implements JedisClientConfiguration {

src/main/java/org/springframework/data/redis/connection/jedis/JedisClientConfiguration.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,13 @@
4545
* <li>Optional client name</li>
4646
* <li>Connect {@link Duration timeout}</li>
4747
* <li>Read {@link Duration timeout}</li>
48+
* <li>Optional {@link Duration topologyRefreshPeriod}
4849
* </ul>
4950
*
5051
* @author Mark Paluch
5152
* @author Christoph Strobl
5253
* @author Chao Chang
54+
* @author Bharat Agarwal
5355
* @since 2.0
5456
* @see redis.clients.jedis.Jedis
5557
* @see org.springframework.data.redis.connection.RedisStandaloneConfiguration
@@ -145,7 +147,7 @@ static JedisClientConfigurationBuilder builder() {
145147
* <dd>2000 msec</dd>
146148
* <dt>Connect Timeout</dt>
147149
* <dd>2000 msec</dd>
148-
* <dt>Toplogy Refresh Period</dt>
150+
* <dt>Topology Refresh Period</dt>
149151
* <dd>null</dd>
150152
* </dl>
151153
*

src/main/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactory.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@
9393
* @author Mark Paluch
9494
* @author Fu Jian
9595
* @author Ajith Kumar
96+
* @author Bharat Agarwal
9697
* @see JedisClientConfiguration
9798
* @see Jedis
9899
*/

src/test/java/org/springframework/data/redis/connection/jedis/JedisClientConfigurationUnitTests.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ void shouldCreateEmptyConfiguration() {
4949
assertThat(configuration.getPoolConfig()).isPresent();
5050
assertThat(configuration.getSslParameters()).isEmpty();
5151
assertThat(configuration.getSslSocketFactory()).isEmpty();
52+
assertThat(configuration.getTopologyRefreshPeriod()).isEmpty();
5253
}
5354

5455
@Test // DATAREDIS-574
@@ -64,6 +65,7 @@ void shouldConfigureAllProperties() throws NoSuchAlgorithmException {
6465
.sslParameters(sslParameters) //
6566
.sslSocketFactory(socketFactory).and() //
6667
.clientName("my-client") //
68+
.topologyRefreshPeriod(Duration.ofMillis(100)) // adding topologyRefreshPeriod
6769
.connectTimeout(Duration.ofMinutes(10)) //
6870
.readTimeout(Duration.ofHours(5)) //
6971
.usePooling().poolConfig(poolConfig) //
@@ -79,6 +81,8 @@ void shouldConfigureAllProperties() throws NoSuchAlgorithmException {
7981
assertThat(configuration.getReadTimeout()).isEqualTo(Duration.ofHours(5));
8082

8183
assertThat(configuration.getPoolConfig()).contains(poolConfig);
84+
85+
assertThat(configuration.getTopologyRefreshPeriod()).isEqualTo(Duration.ofMillis(100));
8286
}
8387

8488
enum MyHostnameVerifier implements HostnameVerifier {

0 commit comments

Comments
 (0)