Apply UPPER function to all columns when enabling ignoreCase.

We now apply the UPPER function regardless of whether we could resolve the criteria property to a column. Previously, we required a resolved property of a String type which prevented non-mapped properties from case-insensitive queries.

Closes #518

Author: mp911de

src/main/java/org/springframework/data/r2dbc/query/QueryMapper.java

@@ -457,7 +457,7 @@ private Condition createCondition(Column column, @Nullable Object mappedValue, C
 		}
 
 		Expression columnExpression = column;
-		if (ignoreCase && String.class == valueType) {
+		if (ignoreCase) {
 			columnExpression = Functions.upper(column);
 		}
 

src/test/java/org/springframework/data/r2dbc/query/QueryMapperUnitTests.java

@@ -155,6 +155,19 @@ public void shouldMapSimpleCriteria() {
 		verify(bindTarget).bind(0, "foo");
 	}
 
+	@Test // gh-518
+	public void shouldMapSimpleCriteriaWithIgnoreCase() {
+
+		Criteria criteria = Criteria.where("some_col").is("foo").ignoreCase(true);
+
+		BoundCondition bindings = map(criteria);
+
+		assertThat(bindings.getCondition()).hasToString("UPPER(person.some_col) = UPPER(?[$1])");
+
+		bindings.getBindings().apply(bindTarget);
+		verify(bindTarget).bind(0, "foo");
+	}
+
 	@Test // gh-300
 	public void shouldMapSimpleCriteriaWithoutEntity() {