Minor changes based on FindBugs findings.

Original pull request #2324

Author: dk2k

src/main/java/org/springframework/data/jpa/convert/QueryByExamplePredicateBuilder.java

@@ -160,7 +160,7 @@ static List<Predicate> getPredicates(String path, CriteriaBuilder cb, Path<?> fr
 				PathNode node = currentNode.add(attribute.getName(), attributeValue);
 				if (node.spansCycle()) {
 					throw new InvalidDataAccessApiUsageException(
-							String.format("Path '%s' from root %s must not span a cyclic property reference!\r\n%s", currentPath,
+							String.format("Path '%s' from root %s must not span a cyclic property reference!%n%s", currentPath,
 									ClassUtils.getShortName(probeType), node));
 				}
 

src/main/java/org/springframework/data/jpa/mapping/JpaPersistentPropertyImpl.java

@@ -333,6 +333,7 @@ private boolean detectUpdatability() {
 				continue;
 			}
 
+			// may cause NullPointerException if the returned value is null
 			return (boolean) AnnotationUtils.getValue(annotation, "updatable");
 		}
 

src/main/java/org/springframework/data/jpa/repository/query/StringQuery.java

@@ -266,8 +266,6 @@ private String parseParameterBindingsOfQueryIntoBindingsAndReturnCleanedQuery(St
 				String expression = spelExtractor.getParameter(parameterName == null ? parameterIndexString : parameterName);
 				String replacement = null;
 
-				Assert.isTrue(parameterIndexString != null || parameterName != null, () -> String.format("We need either a name or an index! Offending query string: %s", query));
-
 				expressionParameterIndex++;
 				if ("".equals(parameterIndexString)) {
 
@@ -293,7 +291,7 @@ private String parseParameterBindingsOfQueryIntoBindingsAndReturnCleanedQuery(St
 						} else {
 							checkAndRegister(new LikeParameterBinding(parameterName, likeType, expression), bindings);
 
-							replacement = expression != null ? ":" + parameterName : matcher.group(5);
+							replacement = ":" + parameterName;
 						}
 
 						break;