Improve JdbcJobExecutionDao::getJobExecution
#5132
Open
+32
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quaff
commented
Dec 5, 2025
| class JobExecutionRowMapper implements RowMapper<JobExecution> { | ||
|
|
||
| private final JobInstance jobInstance; | ||
| private final Function<Long, JobInstance> jobInstanceMapper; |
Contributor
Author
There was a problem hiding this comment.
Not sure the name Mapper and Converter which one is better.
`JOB_INSTANCE_ID` exists in table `JOB_EXECUTION`, no need to query it from table `JOB_INSTANCE`. Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JOB_INSTANCE_IDexists in tableJOB_EXECUTION, no need to query it from tableJOB_INSTANCE.