Skip to content

fix: Remove line breaks in chat client observation handler tests #5048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamespud wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −12
Open

fix: Remove line breaks in chat client observation handler tests #5048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13e1f51
fix: Remove line breaks in chat client observation handler tests
jamespud Dec 6, 2025
55e9cde
fix: correct import format
jamespud Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions ...ringframework/ai/chat/client/observation/ChatClientCompletionObservationHandlerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ void whenEmptyResponseThenOutputNothing(CapturedOutput output) {
this.observationHandler.onStop(context);
assertThat(output).contains("""
INFO o.s.a.c.c.o.ChatClientCompletionObservationHandler -- Chat Client Completion:
[]
""");
[]""");
}

@Test
Expand All @@ -83,8 +82,7 @@ void whenNullResponseThenOutputNothing(CapturedOutput output) {
this.observationHandler.onStop(context);
assertThat(output).contains("""
INFO o.s.a.c.c.o.ChatClientCompletionObservationHandler -- Chat Client Completion:
[]
""");
[]""");
}

@Test
Expand All @@ -102,8 +100,7 @@ void whenResponseWithTextThenOutputIt(CapturedOutput output) {
this.observationHandler.onStop(context);
assertThat(output).contains("""
INFO o.s.a.c.c.o.ChatClientCompletionObservationHandler -- Chat Client Completion:
["Test message"]
""");
["Test message"]""");
}

}
9 changes: 3 additions & 6 deletions ...gframework/ai/chat/client/observation/ChatClientPromptContentObservationHandlerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@ void whenEmptyPromptThenOutputNothing(CapturedOutput output) {
this.observationHandler.onStop(context);
assertThat(output).contains("""
INFO o.s.a.c.c.o.ChatClientPromptContentObservationHandler -- Chat Client Prompt Content:
[]
""");
[]""");
}

@Test
Expand All @@ -76,8 +75,7 @@ void whenPromptWithTextThenOutputIt(CapturedOutput output) {
this.observationHandler.onStop(context);
assertThat(output).contains("""
INFO o.s.a.c.c.o.ChatClientPromptContentObservationHandler -- Chat Client Prompt Content:
["user":"supercalifragilisticexpialidocious"]
""");
["user":"supercalifragilisticexpialidocious"]""");
}

@Test
Expand All @@ -91,8 +89,7 @@ void whenPromptWithMessagesThenOutputIt(CapturedOutput output) {
this.observationHandler.onStop(context);
assertThat(output).contains("""
INFO o.s.a.c.c.o.ChatClientPromptContentObservationHandler -- Chat Client Prompt Content:
["system":"you're a chimney sweep", "user":"supercalifragilisticexpialidocious"]
""");
["system":"you're a chimney sweep", "user":"supercalifragilisticexpialidocious"]""");
}

}