From 13e1f51b3f30ffaa24ac58e9e996beb5d7680e31 Mon Sep 17 00:00:00 2001 From: Wenli Tian Date: Sat, 6 Dec 2025 12:48:17 +0800 Subject: [PATCH 1/2] fix: Remove line breaks in chat client observation handler tests since files are using `LF`, those tests would fail on Windows Signed-off-by: Wenli Tian --- ...atClientCompletionObservationHandlerTests.java | 15 +++++---------- ...lientPromptContentObservationHandlerTests.java | 9 +++------ 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/spring-ai-client-chat/src/test/java/org/springframework/ai/chat/client/observation/ChatClientCompletionObservationHandlerTests.java b/spring-ai-client-chat/src/test/java/org/springframework/ai/chat/client/observation/ChatClientCompletionObservationHandlerTests.java index eb93dc1bfc2..2f7b78da8b8 100644 --- a/spring-ai-client-chat/src/test/java/org/springframework/ai/chat/client/observation/ChatClientCompletionObservationHandlerTests.java +++ b/spring-ai-client-chat/src/test/java/org/springframework/ai/chat/client/observation/ChatClientCompletionObservationHandlerTests.java @@ -16,12 +16,12 @@ package org.springframework.ai.chat.client.observation; -import java.util.List; +import static org.assertj.core.api.Assertions.assertThat; import io.micrometer.observation.Observation; +import java.util.List; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; - import org.springframework.ai.chat.client.ChatClientRequest; import org.springframework.ai.chat.client.ChatClientResponse; import org.springframework.ai.chat.messages.AssistantMessage; @@ -31,8 +31,6 @@ import org.springframework.boot.test.system.CapturedOutput; import org.springframework.boot.test.system.OutputCaptureExtension; -import static org.assertj.core.api.Assertions.assertThat; - /** * Unit tests for {@link ChatClientCompletionObservationHandler}. * @@ -70,8 +68,7 @@ void whenEmptyResponseThenOutputNothing(CapturedOutput output) { this.observationHandler.onStop(context); assertThat(output).contains(""" INFO o.s.a.c.c.o.ChatClientCompletionObservationHandler -- Chat Client Completion: - [] - """); + []"""); } @Test @@ -83,8 +80,7 @@ void whenNullResponseThenOutputNothing(CapturedOutput output) { this.observationHandler.onStop(context); assertThat(output).contains(""" INFO o.s.a.c.c.o.ChatClientCompletionObservationHandler -- Chat Client Completion: - [] - """); + []"""); } @Test @@ -102,8 +98,7 @@ void whenResponseWithTextThenOutputIt(CapturedOutput output) { this.observationHandler.onStop(context); assertThat(output).contains(""" INFO o.s.a.c.c.o.ChatClientCompletionObservationHandler -- Chat Client Completion: - ["Test message"] - """); + ["Test message"]"""); } } diff --git a/spring-ai-client-chat/src/test/java/org/springframework/ai/chat/client/observation/ChatClientPromptContentObservationHandlerTests.java b/spring-ai-client-chat/src/test/java/org/springframework/ai/chat/client/observation/ChatClientPromptContentObservationHandlerTests.java index aafd764488d..80ce5bf6804 100644 --- a/spring-ai-client-chat/src/test/java/org/springframework/ai/chat/client/observation/ChatClientPromptContentObservationHandlerTests.java +++ b/spring-ai-client-chat/src/test/java/org/springframework/ai/chat/client/observation/ChatClientPromptContentObservationHandlerTests.java @@ -64,8 +64,7 @@ void whenEmptyPromptThenOutputNothing(CapturedOutput output) { this.observationHandler.onStop(context); assertThat(output).contains(""" INFO o.s.a.c.c.o.ChatClientPromptContentObservationHandler -- Chat Client Prompt Content: - [] - """); + []"""); } @Test @@ -76,8 +75,7 @@ void whenPromptWithTextThenOutputIt(CapturedOutput output) { this.observationHandler.onStop(context); assertThat(output).contains(""" INFO o.s.a.c.c.o.ChatClientPromptContentObservationHandler -- Chat Client Prompt Content: - ["user":"supercalifragilisticexpialidocious"] - """); + ["user":"supercalifragilisticexpialidocious"]"""); } @Test @@ -91,8 +89,7 @@ void whenPromptWithMessagesThenOutputIt(CapturedOutput output) { this.observationHandler.onStop(context); assertThat(output).contains(""" INFO o.s.a.c.c.o.ChatClientPromptContentObservationHandler -- Chat Client Prompt Content: - ["system":"you're a chimney sweep", "user":"supercalifragilisticexpialidocious"] - """); + ["system":"you're a chimney sweep", "user":"supercalifragilisticexpialidocious"]"""); } } From 55e9cdebeb80c68992960a18c6af201f2284b67a Mon Sep 17 00:00:00 2001 From: Wenli Tian Date: Sat, 6 Dec 2025 13:15:03 +0800 Subject: [PATCH 2/2] fix: correct import format Signed-off-by: Wenli Tian --- .../ChatClientCompletionObservationHandlerTests.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/spring-ai-client-chat/src/test/java/org/springframework/ai/chat/client/observation/ChatClientCompletionObservationHandlerTests.java b/spring-ai-client-chat/src/test/java/org/springframework/ai/chat/client/observation/ChatClientCompletionObservationHandlerTests.java index 2f7b78da8b8..a5dc5768e13 100644 --- a/spring-ai-client-chat/src/test/java/org/springframework/ai/chat/client/observation/ChatClientCompletionObservationHandlerTests.java +++ b/spring-ai-client-chat/src/test/java/org/springframework/ai/chat/client/observation/ChatClientCompletionObservationHandlerTests.java @@ -16,12 +16,12 @@ package org.springframework.ai.chat.client.observation; -import static org.assertj.core.api.Assertions.assertThat; +import java.util.List; import io.micrometer.observation.Observation; -import java.util.List; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; + import org.springframework.ai.chat.client.ChatClientRequest; import org.springframework.ai.chat.client.ChatClientResponse; import org.springframework.ai.chat.messages.AssistantMessage; @@ -31,6 +31,8 @@ import org.springframework.boot.test.system.CapturedOutput; import org.springframework.boot.test.system.OutputCaptureExtension; +import static org.assertj.core.api.Assertions.assertThat; + /** * Unit tests for {@link ChatClientCompletionObservationHandler}. *