Skip to content

Commit b7b0afb

Browse files
committed
removed monolog dependency by adding mocked logger
1 parent cfe70d3 commit b7b0afb

File tree

3 files changed

+20
-6
lines changed

3 files changed

+20
-6
lines changed

composer.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@
3131
"require-dev": {
3232
"phpunit/phpunit": "^9.0.0",
3333
"squizlabs/php_codesniffer": "3.*",
34-
"rogervila/php-sonarqube-scanner": "1.1.0",
35-
"monolog/monolog": "^2.8|^3.0"
34+
"rogervila/php-sonarqube-scanner": "1.1.0"
3635
},
3736

3837
"autoload": {

src/SplitIO/Component/Initialization/LoggerFactory.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,12 @@
1212

1313
class LoggerFactory
1414
{
15+
/**
16+
* Builds defaultLogger
17+
*
18+
* @param $options
19+
* @return SplitIO\Component\Log\Logger
20+
*/
1521
private static function setDefaultLogger(array $options) {
1622
$adapter = (isset($options['adapter'])) ? $options['adapter'] : null;
1723
$level = (isset($options['level'])) ? $options['level'] : null;
@@ -42,6 +48,12 @@ private static function setDefaultLogger(array $options) {
4248
return new Logger($logAdapter, $level);
4349
}
4450

51+
/**
52+
* Builds logger
53+
*
54+
* @param $options
55+
* @return SplitIO\Component\Log\Logger
56+
*/
4557
public static function setupLogger(array $options) {
4658
if (!isset($options['psr3-instance'])) {
4759
return self::setDefaultLogger($options);

tests/Suite/Sdk/SdkClientTest.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
namespace SplitIO\Test\Suite\Sdk;
33

44
use \stdClass;
5-
use Monolog\Logger;
6-
use Monolog\Handler\ErrorLogHandler;
75
use SplitIO\Component\Common\Di;
86
use SplitIO\Test\Suite\Redis\ReflectiveTools;
97
use SplitIO\Component\Cache\ImpressionCache;
@@ -14,6 +12,7 @@
1412
use SplitIO\Component\Cache\SplitCache;
1513
use SplitIO\Sdk\Client;
1614

15+
use SplitIO\Test\Suite\Sdk\Helpers\CustomLogger;
1716
use SplitIO\Test\Utils;
1817

1918
class SdkClientTest extends \PHPUnit\Framework\TestCase
@@ -427,8 +426,12 @@ public function testCustomLog()
427426
{
428427
Di::set(Di::KEY_FACTORY_TRACKER, false);
429428
// create a log channel
430-
$log = new Logger('SplitIO');
431-
$log->pushHandler(new ErrorLogHandler(ErrorLogHandler::OPERATING_SYSTEM, Logger::INFO));
429+
$log = $this
430+
->getMockBuilder('Psr\Log\LoggerInterface')
431+
->disableOriginalConstructor()
432+
->setMethods(array('warning', 'debug', 'error', 'info', 'critical', 'emergency',
433+
'alert', 'notice', 'write', 'log'))
434+
->getMock();
432435

433436
$parameters = array('scheme' => 'redis', 'host' => REDIS_HOST, 'port' => REDIS_PORT, 'timeout' => 881);
434437
$options = array('prefix' => TEST_PREFIX);

0 commit comments

Comments
 (0)