Merge pull request #166 from splitio/feature/metrics

deprecated old telemetry

Author: mmelograno

src/SplitIO/Component/Cache/MetricsCache.php

@@ -4,7 +4,6 @@
 use SplitIO\Component\Cache\EventsCache;
 use SplitIO\Component\Common\Di;
 use SplitIO\Metrics;
-use SplitIO\Component\Cache\MetricsCache;
 use SplitIO\Sdk\Events\EventDTO;
 use SplitIO\Sdk\Events\EventQueueMessage;
 use SplitIO\Sdk\QueueMetadataMessage;
@@ -247,11 +246,6 @@ private function registerData($impressions, $attributes, $metricName, $latency =
             if (isset($this->impressionListener)) {
                 $this->impressionListener->sendDataToClient($impressions, $attributes);
             }
-
-            //Register latency value
-            if (!is_null($latency)) {
-                MetricsCache::addLatencyOnBucket($metricName, Metrics::getBucketForLatencyMicros($latency));
-            }
         } catch (\Exception $e) {
             SplitApp::logger()->critical(
                 ': An exception occurred when trying to store impressions.'

src/SplitIO/Sdk/Client.php

@@ -3,7 +3,6 @@
 namespace SplitIO\Test\Suite\Component;
 
 use SplitIO\Component\Cache\ImpressionCache;
-use SplitIO\Component\Cache\MetricsCache;
 use SplitIO\Component\Cache\SplitCache;
 use SplitIO\Component\Cache\SegmentCache;
 use SplitIO\Component\Cache\TrafficTypeCache;
@@ -18,48 +17,6 @@ private static function getStaticMethodAsPublic($className, $methodName)
         return $refMethod;
     }
 
-    public function testMetricsGetCacheKeyForLatencyButcket()
-    {
-        $method = self::getStaticMethodAsPublic('SplitIO\Component\Cache\MetricsCache', 'getCacheKeyForLatencyBucket');
-        $key = $method->invoke(null, 'abc', 'def');
-        $this->assertEquals(
-            $key,
-            'SPLITIO/php-' . \SplitIO\version() . '/' . \SplitIO\getHostIpAddress() . '/latency.abc.bucket.def'
-        );
-    }
-
-    public function testGetCacheKeySearchLatencyPattern()
-    {
-        $method = self::getStaticMethodAsPublic('SplitIO\Component\Cache\MetricsCache', 'getCacheKeySearchLatencyPattern');
-        $key = $method->invoke(null);
-        $this->assertEquals(
-            $key,
-            'SPLITIO/php-' . \SplitIO\version() . '/' . \SplitIO\getHostIpAddress() . '/latency.*.bucket.*'
-        );
-    }
-
-    public function testGetMetricNameFromKey()
-    {
-        $method = self::getStaticMethodAsPublic('SplitIO\Component\Cache\MetricsCache', 'getMetricNameFromKey');
-        $metricName = $method->invoke(
-            null,
-            'SPLITIO/php-' . \SplitIO\version() . '/' . \SplitIO\getHostIpAddress() . '/latency.abc.bucket.def'
-        );
-
-        $this->assertEquals($metricName, 'abc');
-    }
-
-    public function testGetBucketFromKey()
-    {
-        $method = self::getStaticMethodAsPublic('SplitIO\Component\Cache\MetricsCache', 'getBucketFromKey');
-        $metricName = $method->invoke(
-            null,
-            'SPLITIO/php-' . \SplitIO\version() . '/' . \SplitIO\getHostIpAddress() . '/latency.abc.bucket.def'
-        );
-
-        $this->assertEquals($metricName, 'def');
-    }
-
     public function testSplitGetCacheKeyForSinceParameter()
     {
         $method = self::getStaticMethodAsPublic('SplitIO\Component\Cache\SplitCache', 'getCacheKeyForSinceParameter');