add setting to revalidate stale connections

Author: patricioe

client/CHANGES.txt

@@ -1,5 +1,8 @@
 CHANGES
 
+4.1.7 (Apr 15, 2021)
+- add validateAfterInactivityInMillis to config to help with stale connection handling
+
 4.1.6 (Apr 15, 2021)
 -Updated log level and message in some messages.
 

client/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <groupId>io.split.client</groupId>
         <artifactId>java-client-parent</artifactId>
-        <version>4.1.6</version>
+        <version>4.1.7-rc1</version>
     </parent>
     <artifactId>java-client</artifactId>
     <packaging>jar</packaging>
@@ -171,7 +171,7 @@
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-log4j12</artifactId>
             <version>1.7.21</version>
-            <scope>test</scope>
+<!--            <scope>test</scope>-->
         </dependency>
         <dependency>
             <groupId>org.glassfish.jersey.media</groupId>

client/src/main/java/io/split/client/SplitClientConfig.java

@@ -46,6 +46,7 @@ public class SplitClientConfig {
     private final int _streamingReconnectBackoffBase;
     private final String _authServiceURL;
     private final String _streamingServiceURL;
+    private long _validateAfterInactivityInMillis;
 
     // Proxy configs
     private final HttpHost _proxy;
@@ -89,7 +90,8 @@ private SplitClientConfig(String endpoint,
                               int authRetryBackoffBase,
                               int streamingReconnectBackoffBase,
                               String authServiceURL,
-                              String streamingServiceURL) {
+                              String streamingServiceURL,
+                              long validateAfterInactivityInMillis) {
         _endpoint = endpoint;
         _eventsEndpoint = eventsEndpoint;
         _featuresRefreshRate = pollForFeatureChangesEveryNSeconds;
@@ -120,6 +122,7 @@ private SplitClientConfig(String endpoint,
         _streamingReconnectBackoffBase = streamingReconnectBackoffBase;
         _authServiceURL = authServiceURL;
         _streamingServiceURL = streamingServiceURL;
+        _validateAfterInactivityInMillis = validateAfterInactivityInMillis;
 
         Properties props = new Properties();
         try {
@@ -248,6 +251,10 @@ public String streamingServiceURL() {
         return _streamingServiceURL;
     }
 
+    public long validateAfterInactivityInMillis() {
+        return _validateAfterInactivityInMillis;
+    }
+
     public static final class Builder {
 
         private String _endpoint = "https://sdk.split.io";
@@ -283,6 +290,7 @@ public static final class Builder {
         private int _streamingReconnectBackoffBase = 1;
         private String _authServiceURL = "https://auth.split.io/api/auth";
         private String _streamingServiceURL = "https://streaming.split.io/sse";
+        private long _validateAfterInactivityInMillis = -1;
 
         public Builder() {
         }
@@ -674,6 +682,16 @@ public Builder streamingServiceURL(String streamingServiceURL) {
             return this;
         }
 
+        /**
+         * Set the time after which period of inactivity a connection must be revalidated .
+         * @param validateAfterInactivityInMillis
+         * @return
+         */
+        public Builder validateAfterInactivityInMillis(long validateAfterInactivityInMillis) {
+            _validateAfterInactivityInMillis = validateAfterInactivityInMillis;
+            return this;
+        }
+
         public SplitClientConfig build() {
             if (_featuresRefreshRate < 5 ) {
                 throw new IllegalArgumentException("featuresRefreshRate must be >= 5: " + _featuresRefreshRate);
@@ -774,7 +792,8 @@ public SplitClientConfig build() {
                     _authRetryBackoffBase,
                     _streamingReconnectBackoffBase,
                     _authServiceURL,
-                    _streamingServiceURL);
+                    _streamingServiceURL,
+                    _validateAfterInactivityInMillis);
         }
     }
 }

client/src/main/java/io/split/client/SplitFactoryImpl.java

@@ -43,6 +43,7 @@
 import org.apache.hc.core5.http.io.SocketConfig;
 import org.apache.hc.core5.http.ssl.TLS;
 import org.apache.hc.core5.ssl.SSLContexts;
+import org.apache.hc.core5.util.TimeValue;
 import org.apache.hc.core5.util.Timeout;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -210,7 +211,7 @@ private static CloseableHttpClient buildHttpClient(String apiToken, SplitClientC
 
         SSLConnectionSocketFactory sslSocketFactory = SSLConnectionSocketFactoryBuilder.create()
                 .setSslContext(SSLContexts.createSystemDefault())
-                .setTlsVersions(TLS.V_1_1, TLS.V_1_2)
+                .setTlsVersions(TLS.V_1_2)
                 .build();
 
         RequestConfig requestConfig = RequestConfig.custom()
@@ -223,9 +224,11 @@ private static CloseableHttpClient buildHttpClient(String apiToken, SplitClientC
                 .setDefaultSocketConfig(SocketConfig.custom()
                         .setSoTimeout(Timeout.ofMilliseconds(config.readTimeout()))
                         .build())
+                .setValidateAfterInactivity(TimeValue.ofMilliseconds(config.validateAfterInactivityInMillis()))
+                .setConnectionTimeToLive(TimeValue.ofMilliseconds(2000))
                 .build();
-        cm.setMaxTotal(20);
-        cm.setDefaultMaxPerRoute(20);
+        cm.setMaxTotal(2);
+        cm.setDefaultMaxPerRoute(2);
 
         HttpClientBuilder httpClientbuilder = HttpClients.custom()
                 .setConnectionManager(cm)
@@ -249,7 +252,7 @@ private static CloseableHttpClient buildSSEdHttpClient(SplitClientConfig config)
 
         SSLConnectionSocketFactory sslSocketFactory = SSLConnectionSocketFactoryBuilder.create()
                 .setSslContext(SSLContexts.createSystemDefault())
-                .setTlsVersions(TLS.V_1_1, TLS.V_1_2)
+                .setTlsVersions(TLS.V_1_2)
                 .build();
 
         PoolingHttpClientConnectionManager cm = PoolingHttpClientConnectionManagerBuilder.create()

pom.xml

@@ -4,7 +4,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>io.split.client</groupId>
     <artifactId>java-client-parent</artifactId>
-    <version>4.1.6</version>
+    <version>4.1.7-rc1</version>
     <dependencyManagement>
         <dependencies>
             <dependency>

testing/pom.xml

@@ -6,7 +6,7 @@
     <parent>
         <groupId>io.split.client</groupId>
         <artifactId>java-client-parent</artifactId>
-        <version>4.1.6</version>
+        <version>4.1.7-rc1</version>
     </parent>
 
     <artifactId>java-client-testing</artifactId>