fix bug where cep filter in base search wasn't converting units correctly and remove checks

Sean Sullivan · Sean Sullivan · commit 4fcbccac8e7b · 2023-06-02T15:39:44.000-04:00
diff --git a/elastic_datashader/elastic.py b/elastic_datashader/elastic.py
@@ -153,7 +153,7 @@ def convert_nm_to_ellipse_units(distance: float, units: str) -> float:
         return distance / 2  # semi-axis nautical miles to full-axis meters
 
     if units == "semi_majmin_m":
-        return distance * 2 * 1852  # semi-axis meters to full-axis meters
+        return (distance / 2) * 1852  # semi-axis meters to full-axis meters
 
     # NB. assume "majmin_m" if any others
     return distance * 1852
diff --git a/elastic_datashader/tilegen.py b/elastic_datashader/tilegen.py
@@ -404,9 +404,6 @@ def create_datashader_ellipses_from_search(
         )
 
         for ellipse in ellipse_generator(hit, field_names, ellipse_units):
-            # expel above CEP limit
-            if ellipse.major_meters > search_meters or ellipse.minor_meters > search_meters:
-                continue
 
             x_points, y_points = ellipse_points(ellipse)
 

Original file line number	Diff line number	Diff line change
`@@ -404,9 +404,6 @@ def create_datashader_ellipses_from_search(`
`404`	`404`	`)`
`405`	`405`
`406`	`406`	`for ellipse in ellipse_generator(hit, field_names, ellipse_units):`
`407`		`- # expel above CEP limit`
`408`		`- if ellipse.major_meters > search_meters or ellipse.minor_meters > search_meters:`
`409`		`- continue`
`410`	`407`
`411`	`408`	`x_points, y_points = ellipse_points(ellipse)`
`412`	`409`