Skip to content

incorrect offsets when parsing dependencies from binary format #16

@matt-dbs

Description

@matt-dbs

Parser.hpp contains the following at line 511:

uint32_t depnode = (uint32_t) *( (uint32_t*) (start_of_apdx + (deps_startoffset_in_apdx + cnt)*sizeof(uint32_t)));

Shouldn’t this be

uint32_t depnode = (uint32_t) *( (uint32_t*) (start_of_apdx + deps_startoffset_in_apdx + cnt * sizeof(uint32_t)));

? I.e. the offset into the file where the dependencies list is stored shouldn’t be included in the stride, right? Similarly for line 525 when reading the start dependencies.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions