Installation issue: netlib-scalapack@2.1.0 checksum mismatch due to Netlib vs GitHub tarball

[leopekkas]

Steps to reproduce the issue

$ spack install netlib-scalapack@2.1.0

Error message

Error message

==> Error: ChecksumError: sha256 checksum failed for /local_scratch/sarastel/spack-stage/spack-stage-netlib-scalapack-2.1.0-hulqwbci32sa27pzcyxpap2mrishpxo3/scalapack-2.1.0.tgz
    Expected f03fda720a152030b582a237f8387014da878b84cbd43c568390e9f05d24617f but got 61d9216cf81d246944720cfce96255878a3f85dec13b9351f1fa0fd6768220a6. File size = 5307441 bytes. Contents = b'\x1f\x8b\x08\x00\xc9\x8f\xdd]\x00\x03\xec\\\xdbr\xdbH...?\xfe\xe3?\x13\x9f\xff\x1f\x93\xe4\xb3\xb2\x00\xe8\x06\x02'. URL = https://www.netlib.org/scalapack/scalapack-2.1.0.tgz

Information on your system

• Spack: 1.2.0.dev0 (spack/spack@54135ed)
• Builtin repo: 0f81f51
• Python: 3.6.8
• Platform: linux-rhel8-x86_64_v3

Additional information

The Spack package for netlib-scalapack downloads the 2.1.0 source from Netlib

https://www.netlib.org/scalapack/scalapack-2.1.0.tgz

but the checksum recorded in the package matches the GitHub release archive instead:

https://github.com/Reference-ScaLAPACK/scalapack/archive/refs/tags/v2.1.0.tar.gz

Cause

The package switches download sources depending on version:

def url_for_version(self, version):
    if self.spec.satisfies("@2.2:"):
        return super().url_for_version(version)
    url_fmt = "https://www.netlib.org/scalapack/scalapack-{0}.tgz"
    return url_fmt.format(version)

Versions <2.2 are downloaded from Netlib, but the checksum for 2.1.0 corresponds to the GitHub archive.

Fix here can be achieved either by:

- if self.spec.satisfies("@2.2:"):
+ if self.spec.satisfies("@2.1:"):

Or, more simply, updating the checksum that matches https://www.netlib.org/scalapack/scalapack-2.1.0.tgz:

- version("2.1.0", sha256="f03fda720a152030b582a237f8387014da878b84cbd43c568390e9f05d24617f")
+ version("2.1.0", sha256="61d9216cf81d246944720cfce96255878a3f85dec13b9351f1fa0fd6768220a6")

@etiennemlb is marked as a maintainer

General information

• I have run spack debug report and reported the version of Spack/Python/Platform
• I have run spack maintainers <name-of-the-package> and @mentioned any maintainers
• I have uploaded the build log and environment files
• I have searched the issues of this repo and believe this is not a duplicate

[leopekkas]

Haven't made a PR about this, since I'm not sure which one of the two links below is the preferred one for v2.1.

• https://www.netlib.org/scalapack/scalapack-2.1.0.tgz
• https://github.com/Reference-ScaLAPACK/scalapack/archive/refs/tags/v2.1.0.tar.gz