Skip to content

Commit e6ab057

Browse files
committed
refactor
1 parent eb01c73 commit e6ab057

File tree

1 file changed

+8
-39
lines changed

1 file changed

+8
-39
lines changed

src/jvmMain/kotlin/spp/protocol/extend/TCPServiceFrameParser.kt

Lines changed: 8 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import io.vertx.core.Vertx
2323
import io.vertx.core.eventbus.DeliveryOptions
2424
import io.vertx.core.eventbus.ReplyException
2525
import io.vertx.core.eventbus.ReplyFailure
26-
import io.vertx.core.json.JsonArray
2726
import io.vertx.core.json.JsonObject
2827
import io.vertx.core.net.NetSocket
2928
import io.vertx.ext.bridge.BridgeEventType
@@ -59,40 +58,15 @@ class TCPServiceFrameParser(val vertx: Vertx, val socket: NetSocket) : Handler<A
5958
deliveryOptions.addHeader(it, frame.getJsonObject("headers").getString(it))
6059
}
6160
vertx.eventBus().request<Any>(
62-
frame.getString("address"),
63-
frame.getJsonObject("body"),
64-
deliveryOptions
61+
frame.getString("address"), frame.getJsonObject("body"), deliveryOptions
6562
).onComplete {
6663
if (it.succeeded()) {
67-
if (it.result().body() is JsonObject) {
68-
FrameHelper.sendFrame(
69-
BridgeEventType.SEND.name.lowercase(),
70-
frame.getString("replyAddress"),
71-
it.result().body(),
72-
socket
73-
)
74-
} else if (it.result().body() is JsonArray) {
75-
FrameHelper.sendFrame(
76-
BridgeEventType.SEND.name.lowercase(),
77-
frame.getString("replyAddress"),
78-
it.result().body(),
79-
socket
80-
)
81-
} else if (it.result().body() is Boolean) {
82-
FrameHelper.sendFrame(
83-
BridgeEventType.SEND.name.lowercase(),
84-
frame.getString("replyAddress"),
85-
it.result().body(),
86-
socket
87-
)
88-
} else {
89-
FrameHelper.sendFrame(
90-
BridgeEventType.SEND.name.lowercase(),
91-
frame.getString("replyAddress"),
92-
JsonObject.mapFrom(it.result().body()),
93-
socket
94-
)
95-
}
64+
FrameHelper.sendFrame(
65+
BridgeEventType.SEND.name.lowercase(),
66+
frame.getString("replyAddress"),
67+
it.result().body(),
68+
socket
69+
)
9670
} else {
9771
FrameHelper.sendFrame(
9872
BridgeEventType.SEND.name.lowercase(),
@@ -108,12 +82,7 @@ class TCPServiceFrameParser(val vertx: Vertx, val socket: NetSocket) : Handler<A
10882
if (body.getString("message")?.startsWith("EventBusException:") == true) {
10983
handleErrorFrame(body.put("address", frame.getString("address")))
11084
} else {
111-
if (body.fieldNames().size == 1 && body.containsKey("value")) {
112-
//todo: understand why can't just re-send body like below
113-
vertx.eventBus().send(frame.getString("address"), body.getValue("value"))
114-
} else {
115-
vertx.eventBus().send(frame.getString("address"), body)
116-
}
85+
vertx.eventBus().send(frame.getString("address"), body)
11786
}
11887
} else {
11988
vertx.eventBus().send(frame.getString("address"), body)

0 commit comments

Comments
 (0)