Skip to content

Commit ddf7b31

Browse files
committed
refactor: remove unused
1 parent d3b5f0b commit ddf7b31

File tree

3 files changed

+6
-17
lines changed

3 files changed

+6
-17
lines changed

plugin/src/main/kotlin/spp/jetbrains/sourcemarker/instrument/InstrumentEventWindowService.kt

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,9 @@ class InstrumentEventWindowService(val project: Project) : Disposable {
186186
}
187187
}
188188

189-
fun showBreakpointHit(hit: LiveBreakpointHit, showExecutionPoint: Boolean = true) {
190-
if (showExecutionPoint) removeExecutionShower()
191-
breakpointHitTab = BreakpointHitTab(project, executionPointHighlighter, showExecutionPoint)
189+
fun showBreakpointHit(hit: LiveBreakpointHit) {
190+
removeExecutionShower()
191+
breakpointHitTab = BreakpointHitTab(project, executionPointHighlighter)
192192

193193
//grab first non-skywalking frame and add real variables from skywalking frame
194194
val stackTrace = hit.stackTrace.copy(
@@ -236,13 +236,5 @@ class InstrumentEventWindowService(val project: Project) : Disposable {
236236
executionPointHighlighter.hide()
237237
}
238238

239-
fun getBreakpointHitTab(): BreakpointHitTab? {
240-
return if (::breakpointHitTab.isInitialized) {
241-
breakpointHitTab
242-
} else {
243-
null
244-
}
245-
}
246-
247239
override fun dispose() = Unit
248240
}

plugin/src/main/kotlin/spp/jetbrains/sourcemarker/instrument/breakpoint/ExecutionPointManager.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,14 @@ import spp.protocol.artifact.exception.sourceAsLineNumber
3939
*/
4040
class ExecutionPointManager(
4141
private val project: Project,
42-
private val executionPointHighlighter: ExecutionPointHighlighter,
43-
private val showExecutionPoint: Boolean = true
42+
private val executionPointHighlighter: ExecutionPointHighlighter
4443
) : ActiveStackTraceListener, Disposable {
4544

4645
companion object {
4746
private val log = logger<ExecutionPointManager>()
4847
}
4948

5049
override fun onChanged(activeStackTrace: ActiveStackTrace) {
51-
if (!showExecutionPoint) return
5250
val currentFrame = activeStackTrace.currentFrame ?: return
5351
val psiFile = activeStackTrace.stackTrace.language?.let {
5452
ArtifactNamingService.getService(it).findPsiFile(it, project, currentFrame)

plugin/src/main/kotlin/spp/jetbrains/sourcemarker/instrument/breakpoint/ui/BreakpointHitTab.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,15 +41,14 @@ import java.util.concurrent.CopyOnWriteArrayList
4141
*/
4242
class BreakpointHitTab(
4343
val project: Project,
44-
executionPointHighlighter: ExecutionPointHighlighter,
45-
showExecutionPoint: Boolean
44+
executionPointHighlighter: ExecutionPointHighlighter
4645
) : Disposable {
4746

4847
companion object {
4948
const val LIVE_RUNNER = "Live Runner"
5049
}
5150

52-
private val executionPointManager = ExecutionPointManager(project, executionPointHighlighter, showExecutionPoint)
51+
private val executionPointManager = ExecutionPointManager(project, executionPointHighlighter)
5352
private val listeners = CopyOnWriteArrayList<ActiveStackTraceListener>()
5453
private val layoutUi = RunnerLayoutUi.Factory.getInstance(project).create(
5554
LIVE_RUNNER, LIVE_RUNNER, LIVE_RUNNER, this

0 commit comments

Comments
 (0)