refactor: move CONDITION_EVALUATION

Author: BFergerson

common/src/main/kotlin/spp/jetbrains/artifact/model/IfArtifact.kt

@@ -17,12 +17,17 @@
 package spp.jetbrains.artifact.model
 
 import com.intellij.psi.PsiElement
+import spp.jetbrains.SourceKey
 
 /**
  * Represents if/elif/else control structures.
  */
 abstract class IfArtifact(psiElement: PsiElement) : ControlStructureArtifact(psiElement) {
 
+    companion object {
+        private val CONDITION_EVALUATION = SourceKey<Boolean>("CONDITION_EVALUATION")
+    }
+
     abstract val condition: ArtifactElement?
     abstract val thenBranch: ArtifactElement?
     abstract val elseBranch: ArtifactElement?
@@ -58,5 +63,27 @@ abstract class IfArtifact(psiElement: PsiElement) : ControlStructureArtifact(psi
         }
     }
 
+    fun setConditionEvaluation(value: Boolean) {
+        data[CONDITION_EVALUATION] = value
+    }
+
+    fun getConditionEvaluation(): Boolean? {
+        return getData(CONDITION_EVALUATION)
+    }
+
+    override fun toString(): String {
+        return buildString {
+            append("IfArtifact(conditionEvaluation=")
+            append(getConditionEvaluation())
+            append(", condition=")
+            append(condition)
+            append(", thenBranch=")
+            append(thenBranch)
+            append(", elseBranch=")
+            append(elseBranch)
+            append(")")
+        }
+    }
+
     abstract override fun clone(): IfArtifact
 }

insight/src/main/kotlin/spp/jetbrains/insight/InsightKeys.kt

@@ -34,7 +34,6 @@ object InsightKeys {
     val PATH_EXECUTION_PROBABILITY = SourceKey<InsightValue<Double>>(InsightType.PATH_EXECUTION_PROBABILITY.name)
     val PATH_DURATION = SourceKey<InsightValue<Double>>(InsightType.PATH_DURATION.name)
     val RECURSIVE_CALL = SourceKey<InsightValue<Boolean>>(InsightType.RECURSIVE_CALL.name)
-    val CONDITION_EVALUATION = SourceKey<Boolean>("CONDITION_EVALUATION")
 
     val ALL_INSIGHTS: List<SourceKey<out InsightValue<out Any>>> = listOf(
         FUNCTION_DURATION,

insight/src/main/kotlin/spp/jetbrains/insight/ProceduralAnalyzer.kt

@@ -118,7 +118,7 @@ class ProceduralAnalyzer {
 
             if (artifactElement is IfArtifact) {
                 val bool = boolIterator.next()
-                artifactElement.data[InsightKeys.CONDITION_EVALUATION] = bool
+                artifactElement.setConditionEvaluation(bool)
 
                 if (bool) {
                     val childArtifacts = processArtifacts[index + 1] as List<Any>

insight/src/main/kotlin/spp/jetbrains/insight/pass/artifact/RandomConditionalPass.kt

@@ -63,7 +63,7 @@ class RandomConditionalPass : ArtifactPass {
             else -> 0.0
         }.let { if (it > 1.0) 1.0 else if (it < 0.0) 0.0 else it }
 
-        val conditionEvaluation = ifArtifact.getData(InsightKeys.CONDITION_EVALUATION)!!
+        val conditionEvaluation = ifArtifact.getConditionEvaluation()!!
         if (conditionEvaluation) {
             ifArtifact.data[InsightKeys.CONTROL_STRUCTURE_PROBABILITY] =
                 InsightValue(InsightType.CONTROL_STRUCTURE_PROBABILITY, probability)

insight/src/main/kotlin/spp/jetbrains/insight/pass/multipath/StaticDfaMultiPathPass.kt

@@ -69,7 +69,7 @@ class StaticDfaMultiPathPass : ProceduralMultiPathPass {
                         if (it is IfArtifact) {
                             if (it.condition?.psiElement == expression) {
                                 val probability = if (value == ConstantValue.TRUE) 1.0 else 0.0
-                                val conditionEvaluation = it.getData(InsightKeys.CONDITION_EVALUATION)!!
+                                val conditionEvaluation = it.getConditionEvaluation()!!
                                 if (conditionEvaluation) {
                                     it.data[InsightKeys.CONTROL_STRUCTURE_PROBABILITY] =
                                         InsightValue(InsightType.CONTROL_STRUCTURE_PROBABILITY, probability)
@@ -90,7 +90,7 @@ class StaticDfaMultiPathPass : ProceduralMultiPathPass {
                         if (it is IfArtifact) {
                             if (it.condition?.psiElement == expression) {
                                 val probability = if (value == ConstantValue.TRUE) 1.0 else 0.0
-                                val conditionEvaluation = it.getData(InsightKeys.CONDITION_EVALUATION)!!
+                                val conditionEvaluation = it.getConditionEvaluation()!!
                                 if (conditionEvaluation) {
                                     it.data[InsightKeys.CONTROL_STRUCTURE_PROBABILITY] =
                                         InsightValue(InsightType.CONTROL_STRUCTURE_PROBABILITY, probability)

insight/src/main/kotlin/spp/jetbrains/insight/pass/path/PathProbabilityPass.kt

@@ -39,7 +39,7 @@ class PathProbabilityPass : ProceduralPathPass {
                 InsightValue.of(PATH_EXECUTION_PROBABILITY, 1.0)
 
             if (it is IfArtifact) {
-                analyze(it, it.getData(InsightKeys.CONDITION_EVALUATION)!!, 1.0)
+                analyze(it, it.getConditionEvaluation()!!, 1.0)
             }
         }
     }
@@ -51,7 +51,7 @@ class PathProbabilityPass : ProceduralPathPass {
                 InsightValue.of(PATH_EXECUTION_PROBABILITY, probability)
 
             if (it is IfArtifact) {
-                analyze(it, it.getData(InsightKeys.CONDITION_EVALUATION)!!, probability)
+                analyze(it, it.getConditionEvaluation()!!, probability)
             }
         }
     }

insight/src/main/kotlin/spp/jetbrains/insight/path/ProceduralPath.kt

@@ -20,7 +20,6 @@ import spp.jetbrains.artifact.model.ArtifactElement
 import spp.jetbrains.artifact.model.CallArtifact
 import spp.jetbrains.artifact.model.FunctionArtifact
 import spp.jetbrains.artifact.model.IfArtifact
-import spp.jetbrains.insight.InsightKeys
 import spp.protocol.insight.InsightValue
 
 /**
@@ -46,7 +45,7 @@ data class ProceduralPath(
             val conditionals = descendants.filterIsInstance<IfArtifact>()
             val conditions = mutableListOf<Pair<Boolean, IfArtifact>>()
             for (i in conditionals.indices) {
-                conditions.add(Pair(conditionals[i].getData(InsightKeys.CONDITION_EVALUATION)!!, conditionals[i]))
+                conditions.add(Pair(conditionals[i].getConditionEvaluation()!!, conditionals[i]))
             }
             return conditions
         }