Skip to content

Increase request maximum size to 4 MB#1039

Merged
jviotti merged 3 commits into
mainfrom
higher-size-caps
Jun 8, 2026
Merged

Increase request maximum size to 4 MB#1039
jviotti merged 3 commits into
mainfrom
higher-size-caps

Conversation

@jviotti

@jviotti jviotti commented Jun 8, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode

augmentcode Bot commented Jun 8, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Increases the default maximum HTTP request body size to 4 MB to better support realistic JSON Schema evaluate/trace payloads.

Changes:

  • Raise HTTPRequest::body() default max_size to 4 * 1024 * 1024 bytes and document 413 mapping.
  • Clarify 413 error messaging for JSON Schema evaluate/trace (REST) and MCP (JSON-RPC) paths.
  • Update the public API error schema’s payload-too-large detail constant to match the new message.
  • Document the 4 MB cap in docs/api.md for evaluate and trace endpoints.
  • Adjust e2e resource-size assertions to reflect the updated schema content.

Technical Notes: The 413 response is aligned with RFC 9110 §15.5.14 (“Content Too Large”).

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/actions/action_mcp_v1.h

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 8 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

jviotti added 2 commits June 8, 2026 16:21
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: f690b89 Previous: 1374bf6 Ratio
Add one schema (0 existing) 382 ms 402 ms 0.95
Add one schema (100 existing) 28 ms 29 ms 0.97
Add one schema (1000 existing) 83 ms 88 ms 0.94
Add one schema (10000 existing) 670 ms 738 ms 0.91
Update one schema (1 existing) 21 ms 22 ms 0.95
Update one schema (101 existing) 28 ms 29 ms 0.97
Update one schema (1001 existing) 86 ms 89 ms 0.97
Update one schema (10001 existing) 692 ms 718 ms 0.96
Cached rebuild (1 existing) 6 ms 6 ms 1
Cached rebuild (101 existing) 8 ms 8 ms 1
Cached rebuild (1001 existing) 28 ms 29 ms 0.97
Cached rebuild (10001 existing) 242 ms 251 ms 0.96
Index 100 schemas 674 ms 680 ms 0.99
Index 1000 schemas 1630 ms 1466 ms 1.11
Index 10000 schemas 14420 ms 13926 ms 1.04
Index 10000 schemas (custom meta-schema) 140926 ms 140587 ms 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: f690b89 Previous: 1374bf6 Ratio
Add one schema (0 existing) 376 ms 409 ms 0.92
Add one schema (100 existing) 30 ms 31 ms 0.97
Add one schema (1000 existing) 87 ms 89 ms 0.98
Add one schema (10000 existing) 990 ms 1026 ms 0.96
Update one schema (1 existing) 23 ms 23 ms 1
Update one schema (101 existing) 30 ms 30 ms 1
Update one schema (1001 existing) 88 ms 90 ms 0.98
Update one schema (10001 existing) 706 ms 730 ms 0.97
Cached rebuild (1 existing) 8 ms 7 ms 1.14
Cached rebuild (101 existing) 9 ms 9 ms 1
Cached rebuild (1001 existing) 29 ms 29 ms 1
Cached rebuild (10001 existing) 243 ms 251 ms 0.97
Index 100 schemas 645 ms 666 ms 0.97
Index 1000 schemas 1621 ms 1606 ms 1.01
Index 10000 schemas 13419 ms 13512 ms 0.99
Index 10000 schemas (custom meta-schema) 136191 ms 138287 ms 0.98

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit de8d2e4 into main Jun 8, 2026
5 checks passed
@jviotti jviotti deleted the higher-size-caps branch June 8, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant