Increase request maximum size to 4 MB#1039
Merged
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: Increases the default maximum HTTP request body size to 4 MB to better support realistic JSON Schema evaluate/trace payloads. Changes:
Technical Notes: The 413 response is aligned with RFC 9110 §15.5.14 (“Content Too Large”). 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
1 issue found across 8 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: f690b89 | Previous: 1374bf6 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
382 ms |
402 ms |
0.95 |
Add one schema (100 existing) |
28 ms |
29 ms |
0.97 |
Add one schema (1000 existing) |
83 ms |
88 ms |
0.94 |
Add one schema (10000 existing) |
670 ms |
738 ms |
0.91 |
Update one schema (1 existing) |
21 ms |
22 ms |
0.95 |
Update one schema (101 existing) |
28 ms |
29 ms |
0.97 |
Update one schema (1001 existing) |
86 ms |
89 ms |
0.97 |
Update one schema (10001 existing) |
692 ms |
718 ms |
0.96 |
Cached rebuild (1 existing) |
6 ms |
6 ms |
1 |
Cached rebuild (101 existing) |
8 ms |
8 ms |
1 |
Cached rebuild (1001 existing) |
28 ms |
29 ms |
0.97 |
Cached rebuild (10001 existing) |
242 ms |
251 ms |
0.96 |
Index 100 schemas |
674 ms |
680 ms |
0.99 |
Index 1000 schemas |
1630 ms |
1466 ms |
1.11 |
Index 10000 schemas |
14420 ms |
13926 ms |
1.04 |
Index 10000 schemas (custom meta-schema) |
140926 ms |
140587 ms |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: f690b89 | Previous: 1374bf6 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
376 ms |
409 ms |
0.92 |
Add one schema (100 existing) |
30 ms |
31 ms |
0.97 |
Add one schema (1000 existing) |
87 ms |
89 ms |
0.98 |
Add one schema (10000 existing) |
990 ms |
1026 ms |
0.96 |
Update one schema (1 existing) |
23 ms |
23 ms |
1 |
Update one schema (101 existing) |
30 ms |
30 ms |
1 |
Update one schema (1001 existing) |
88 ms |
90 ms |
0.98 |
Update one schema (10001 existing) |
706 ms |
730 ms |
0.97 |
Cached rebuild (1 existing) |
8 ms |
7 ms |
1.14 |
Cached rebuild (101 existing) |
9 ms |
9 ms |
1 |
Cached rebuild (1001 existing) |
29 ms |
29 ms |
1 |
Cached rebuild (10001 existing) |
243 ms |
251 ms |
0.97 |
Index 100 schemas |
645 ms |
666 ms |
0.97 |
Index 1000 schemas |
1621 ms |
1606 ms |
1.01 |
Index 10000 schemas |
13419 ms |
13512 ms |
0.99 |
Index 10000 schemas (custom meta-schema) |
136191 ms |
138287 ms |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com