enhance: hiding invisible controls when commit details panel is collapsed

Signed-off-by: leo <longshuang@msn.cn>

Author: love-linger

src/Views/CommitDetail.axaml

@@ -8,7 +8,8 @@
              xmlns:c="using:SourceGit.Converters"
              mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"
              x:Class="SourceGit.Views.CommitDetail"
-             x:DataType="vm:CommitDetail">
+             x:DataType="vm:CommitDetail"
+             x:Name="ThisControl">
   <TabControl SelectedIndex="{Binding ActiveTabIndex, Mode=TwoWay}" Padding="0,4">
     <!-- Information Page -->
     <TabItem>
@@ -18,7 +19,10 @@
         </Border>
       </TabItem.Header>
 
-      <ScrollViewer Margin="4,0,0,0" Offset="{Binding ScrollOffset, Mode=TwoWay}" HorizontalScrollBarVisibility="Disabled" VerticalScrollBarVisibility="Auto">
+      <ScrollViewer Margin="4,0,0,0"
+                    Offset="{Binding ScrollOffset, Mode=TwoWay}"
+                    HorizontalScrollBarVisibility="Disabled" VerticalScrollBarVisibility="Auto"
+                    IsVisible="{Binding #ThisControl.IsDetailsPanelExpanded, Mode=OneWay}">
         <StackPanel Orientation="Vertical">
           <!-- Base Information -->
           <v:CommitBaseInfo Content="{Binding Commit}"
@@ -89,7 +93,8 @@
           <TextBlock Classes="tab_header" Text="{DynamicResource Text.CommitDetail.Changes}"/>
         </Border>
       </TabItem.Header>
-      <v:CommitChanges Margin="4,0"/>
+      <v:CommitChanges Margin="4,0"
+                       IsVisible="{Binding #ThisControl.IsDetailsPanelExpanded, Mode=OneWay}"/>
     </TabItem>
 
     <TabItem>
@@ -98,7 +103,8 @@
           <TextBlock Classes="tab_header" Text="{DynamicResource Text.CommitDetail.Files}"/>
         </Border>
       </TabItem.Header>
-      <v:RevisionFiles Margin="4,0"/>
+      <v:RevisionFiles Margin="4,0"
+                       IsVisible="{Binding #ThisControl.IsDetailsPanelExpanded, Mode=OneWay}"/>
     </TabItem>
   </TabControl>
 </UserControl>

src/Views/CommitDetail.axaml.cs

@@ -3,6 +3,7 @@
 using System.IO;
 using System.Text;
 
+using Avalonia;
 using Avalonia.Controls;
 using Avalonia.Input;
 using Avalonia.LogicalTree;
@@ -13,6 +14,15 @@ namespace SourceGit.Views
 {
     public partial class CommitDetail : UserControl
     {
+        public static readonly StyledProperty<bool> IsDetailsPanelExpandedProperty =
+            AvaloniaProperty.Register<CommitDetail, bool>(nameof(IsDetailsPanelExpanded));
+
+        public bool IsDetailsPanelExpanded
+        {
+            get => GetValue(IsDetailsPanelExpandedProperty);
+            set => SetValue(IsDetailsPanelExpandedProperty, value);
+        }
+
         public CommitDetail()
         {
             InitializeComponent();

src/Views/Histories.axaml

@@ -268,14 +268,8 @@
                   HorizontalAlignment="Stretch" VerticalAlignment="Stretch"
                   Background="{DynamicResource Brush.Window}"
                   BorderBrush="{DynamicResource Brush.Border0}"
-                  Focusable="False">
-      <GridSplitter.IsEnabled>
-        <MultiBinding Converter="{x:Static BoolConverters.Or}">
-          <Binding Source="{x:Static vm:Preferences.Instance}" Path="UseTwoColumnsLayoutInHistories"/>
-          <Binding Path="IsCollapseDetails" Converter="{x:Static BoolConverters.Not}"/>
-        </MultiBinding>
-      </GridSplitter.IsEnabled>
-    </GridSplitter>
+                  Focusable="False"
+                  IsVisible="{Binding #ThisControl.IsDetailsPanelExpanded, Mode=OneWay}"/>
 
     <Grid Grid.Row="2" Grid.Column="0" Grid.ColumnSpan="3">
       <ContentControl>
@@ -290,7 +284,7 @@
                     </Border>
                   </TabItem.Header>
 
-                  <Grid Margin="0,32,0,0" ClipToBounds="True">
+                  <Grid IsVisible="{Binding #ThisControl.IsDetailsPanelExpanded, Mode=OneWay}">
                     <Path Width="128" Height="128"
                           Data="{StaticResource Icons.Detail}"
                           HorizontalAlignment="Center"
@@ -323,7 +317,7 @@
 
         <ContentControl.DataTemplates>
           <DataTemplate DataType="vm:CommitDetail">
-            <v:CommitDetail/>
+            <v:CommitDetail IsDetailsPanelExpanded="{Binding #ThisControl.IsDetailsPanelExpanded, Mode=OneWay}"/>
           </DataTemplate>
 
           <DataTemplate DataType="vm:RevisionCompare">
@@ -341,7 +335,7 @@
                   </Border>
                 </TabItem.Header>
 
-                <v:RevisionCompare/>
+                <v:RevisionCompare IsVisible="{Binding #ThisControl.IsDetailsPanelExpanded, Mode=OneWay}"/>
               </TabItem>
 
               <TabItem IsEnabled="False">
@@ -361,7 +355,10 @@
                   </Border>
                 </TabItem.Header>
 
-                <StackPanel ClipToBounds="True" Orientation="Vertical" HorizontalAlignment="Center" VerticalAlignment="Center">
+                <StackPanel Orientation="Vertical"
+                            HorizontalAlignment="Center" VerticalAlignment="Center"
+                            IsVisible="{Binding #ThisControl.IsDetailsPanelExpanded, Mode=OneWay}">
+                  
                   <Path Width="128" Height="128"
                         Data="{StaticResource Icons.Detail}"
                         HorizontalAlignment="Center"

src/Views/Histories.axaml.cs

@@ -294,6 +294,15 @@ public bool IsScrollToTopVisible
             set => SetValue(IsScrollToTopVisibleProperty, value);
         }
 
+        public static readonly StyledProperty<bool> IsDetailsPanelExpandedProperty =
+            AvaloniaProperty.Register<Histories, bool>(nameof(IsDetailsPanelExpanded), true);
+
+        public bool IsDetailsPanelExpanded
+        {
+            get => GetValue(IsDetailsPanelExpandedProperty);
+            set => SetValue(IsDetailsPanelExpandedProperty, value);
+        }
+
         public Histories()
         {
             InitializeComponent();

src/Views/Repository.axaml

@@ -926,7 +926,14 @@
               <v:Histories CurrentBranch="{Binding CurrentBranch, Mode=OneWay}"
                            Bisect="{Binding Bisect, Mode=OneWay}"
                            IssueTrackers="{Binding IssueTrackers, Mode=OneWay}"
-                           OnlyHighlightCurrentBranch="{Binding HighlightCurrentBranchOnly, Mode=OneWay}"/>
+                           OnlyHighlightCurrentBranch="{Binding HighlightCurrentBranchOnly, Mode=OneWay}">
+                <v:Histories.IsDetailsPanelExpanded>
+                  <MultiBinding Converter="{x:Static BoolConverters.Or}">
+                    <Binding Source="{x:Static vm:Preferences.Instance}" Path="UseTwoColumnsLayoutInHistories" Mode="OneWay"/>
+                    <Binding Path="IsCollapseDetails" Converter="{x:Static BoolConverters.Not}" Mode="OneWay"/>
+                  </MultiBinding>
+                </v:Histories.IsDetailsPanelExpanded>
+              </v:Histories>
             </DataTemplate>
           </ContentControl.DataTemplates>
         </ContentControl>