Merge branch 'migrate/avoid_global_state' into migrate/avoid_debug_print_in_release

Author: Islam-Shaaban-Ibrahim

lib/main.dart

@@ -3,10 +3,16 @@ import 'package:analysis_server_plugin/registry.dart';
 import 'package:solid_lints/src/lints/avoid_debug_print_in_release/avoid_debug_print_in_release_rule.dart';
 import 'package:solid_lints/src/lints/avoid_global_state/avoid_global_state_rule.dart';
 
-/// create plugin
+/// The entry point for the Solid Lints analyser server plugin.
+///
+/// This plugin integrates custom lint rules into the Dart analysis server,
+/// allowing them to run during static analysis.
 final plugin = SolidLintsPlugin();
 
-/// create plugin class
+/// An analysis server plugin that provides Solid lint rules.
+///
+/// This plugin registers custom lint rules and enables them to be executed
+/// by the Dart analyzer during code analysis.
 class SolidLintsPlugin extends Plugin {
   @override
   String get name => 'solid_lints';

lib/src/lints/avoid_debug_print_in_release/avoid_debug_print_in_release_rule.dart

@@ -1,10 +1,8 @@
 import 'package:analyzer/analysis_rule/analysis_rule.dart';
 import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/analysis_rule/rule_visitor_registry.dart';
-import 'package:analyzer/dart/ast/ast.dart';
-import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/error/error.dart';
-import 'package:solid_lints/src/lints/avoid_debug_print_in_release/avoid_debug_print_in_release_rule_visitor.dart';
+import 'package:solid_lints/src/lints/avoid_debug_print_in_release/visitors/avoid_debug_print_in_release_visitor.dart';
 
 /// An `avoid_debug_print_in_release` rule which forbids calling or referencing
 /// debugPrint function from flutter/foundation in release mode.
@@ -55,7 +53,7 @@ class AvoidDebugPrintInReleaseRule extends AnalysisRule {
     RuleVisitorRegistry registry,
     RuleContext context,
   ) {
-    final visitor = AvoidDebugPrintInReleaseRuleVisitor(this);
+    final visitor = AvoidDebugPrintInReleaseVisitor(this);
     registry.addMethodInvocation(this, visitor);
     registry.addSimpleIdentifier(this, visitor);
   }

…debug_print_in_release_rule_visitor.dart …void_debug_print_in_release_visitor.dartlib/src/lints/avoid_debug_print_in_release/visitors/avoid_debug_print_in_release_rule_visitor.dart renamed to lib/src/lints/avoid_debug_print_in_release/visitors/avoid_debug_print_in_release_visitor.dart lib/src/lints/avoid_debug_print_in_release/visitors/avoid_debug_print_in_release_rule_visitor.dart renamed to lib/src/lints/avoid_debug_print_in_release/visitors/avoid_debug_print_in_release_visitor.dart

@@ -3,12 +3,12 @@ import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:solid_lints/src/lints/avoid_debug_print_in_release/avoid_debug_print_in_release_rule.dart';
 
 /// Visitor for [AvoidDebugPrintInReleaseRule].
-class AvoidDebugPrintInReleaseRuleVisitor extends SimpleAstVisitor<void> {
+class AvoidDebugPrintInReleaseVisitor extends SimpleAstVisitor<void> {
   /// The rule associated with this visitor.
   final AvoidDebugPrintInReleaseRule rule;
 
-  /// Creates an instance of [AvoidDebugPrintInReleaseRuleVisitor].
-  AvoidDebugPrintInReleaseRuleVisitor(this.rule);
+  /// Creates an instance of [AvoidDebugPrintInReleaseVisitor].
+  AvoidDebugPrintInReleaseVisitor(this.rule);
 
   @override
   void visitMethodInvocation(MethodInvocation node) {

lib/src/lints/avoid_global_state/avoid_global_state_rule.dart

@@ -2,7 +2,7 @@ import 'package:analyzer/analysis_rule/analysis_rule.dart';
 import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/analysis_rule/rule_visitor_registry.dart';
 import 'package:analyzer/error/error.dart';
-import 'package:solid_lints/src/lints/avoid_global_state/avoid_global_state_rule_visitor.dart';
+import 'package:solid_lints/src/lints/avoid_global_state/visitors/avoid_global_state_visitor.dart';
 
 /// Avoid top-level and static mutable variables.
 ///
@@ -61,7 +61,7 @@ class AvoidGlobalStateRule extends AnalysisRule {
     RuleVisitorRegistry registry,
     RuleContext context,
   ) {
-    final visitor = AvoidGlobalStateRuleVisitor(this);
+    final visitor = AvoidGlobalStateVisitor(this);
 
     registry.addTopLevelVariableDeclaration(this, visitor);
     registry.addFieldDeclaration(this, visitor);

…ate/avoid_global_state_rule_visitor.dart …visitors/avoid_global_state_visitor.dartlib/src/lints/avoid_global_state/avoid_global_state_rule_visitor.dart renamed to lib/src/lints/avoid_global_state/visitors/avoid_global_state_visitor.dart lib/src/lints/avoid_global_state/avoid_global_state_rule_visitor.dart renamed to lib/src/lints/avoid_global_state/visitors/avoid_global_state_visitor.dart

@@ -3,12 +3,12 @@ import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:solid_lints/src/lints/avoid_global_state/avoid_global_state_rule.dart';
 
 /// Visitor for [AvoidGlobalStateRule].
-class AvoidGlobalStateRuleVisitor extends SimpleAstVisitor<void> {
+class AvoidGlobalStateVisitor extends SimpleAstVisitor<void> {
   /// The rule this visitor is associated with.
   final AvoidGlobalStateRule rule;
 
-  /// Creates an instance of [AvoidGlobalStateRuleVisitor].
-  AvoidGlobalStateRuleVisitor(this.rule);
+  /// Creates an instance of [AvoidGlobalStateVisitor].
+  AvoidGlobalStateVisitor(this.rule);
 
   @override
   void visitTopLevelVariableDeclaration(TopLevelVariableDeclaration node) {

lint_test/pubspec.yaml

@@ -12,4 +12,4 @@ dependencies:
 dev_dependencies:
   solid_lints:
     path: ../
-  
+  test: ^1.20.1

pubspec.yaml

@@ -26,5 +26,3 @@ dev_dependencies:
   args: ^2.6.0
   analyzer_testing: ^0.1.9
   test_reflective_loader: ^0.3.0
-  test: ^1.25.0
-

test/avoid_global_state_rule_test.dart

@@ -66,7 +66,7 @@ class Test {
 ''');
   }
 
-  void test_does_not_report_local_method_variables() async {
+  void test_does_not_report_local_variables() async {
     await assertNoDiagnostics(r'''
 void m() {
   int localMutable = 0;