Skip to content

Commit 8edd521

Browse files
refactor: use AutoTestLintOffsets
1 parent 11338b8 commit 8edd521

1 file changed

Lines changed: 22 additions & 32 deletions

File tree

test/lints/prefer_first/prefer_first_rule_test.dart

Lines changed: 22 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -2,34 +2,33 @@ import 'package:analyzer_testing/analysis_rule/analysis_rule.dart';
22
import 'package:solid_lints/src/lints/prefer_first/prefer_first_rule.dart';
33
import 'package:test_reflective_loader/test_reflective_loader.dart';
44

5+
import '../auto_test_lint_offsets.dart';
6+
57
void main() {
68
defineReflectiveSuite(() {
79
defineReflectiveTests(PreferFirstRuleTest);
810
});
911
}
1012

1113
@reflectiveTest
12-
class PreferFirstRuleTest extends AnalysisRuleTest {
14+
class PreferFirstRuleTest extends AnalysisRuleTest with AutoTestLintOffsets {
1315
@override
1416
void setUp() {
1517
rule = PreferFirstRule();
1618
super.setUp();
1719
}
1820

1921
void test_reports_on_list_index_access_with_zero_literal() async {
20-
await assertDiagnostics(
21-
r'''
22+
await assertAutoDiagnostics('''
2223
final list1 = [0, 1, 2, 3];
23-
var a = list1[0];
24+
var a = ${expectLint('list1[0]')};
2425
2526
void main () {
2627
final list2 = [1, 0, 2, 3];
27-
list1[0];
28-
list2[0];
28+
${expectLint('list1[0]')};
29+
${expectLint('list2[0]')};
2930
}
30-
''',
31-
[lint(36, 8), lint(94, 8), lint(106, 8)],
32-
);
31+
''');
3332
}
3433

3534
void
@@ -47,32 +46,26 @@ var c = list[zeroVar];
4746
}
4847

4948
void test_reports_on_list_subclasses() async {
50-
await assertDiagnostics(
51-
r'''
49+
await assertAutoDiagnostics('''
5250
abstract class MyList<T> implements List<T> {}
5351
5452
T getFirst<T>(MyList<T> list) {
55-
return list[0];
53+
return ${expectLint('list[0]')};
5654
}
57-
''',
58-
[lint(89, 7)],
59-
);
55+
''');
6056
}
6157

6258
void test_reports_on_element_at_access_with_zero_literal() async {
63-
await assertDiagnostics(
64-
r'''
59+
await assertAutoDiagnostics('''
6560
final list1 = [0, 1, 2, 3];
66-
var a = list1.elementAt(0);
61+
var a = ${expectLint('list1.elementAt(0)')};
6762
6863
void main () {
6964
final list2 = [1, 0, 2, 3];
70-
list1.elementAt(0);
71-
list2.elementAt(0);
65+
${expectLint('list1.elementAt(0)')};
66+
${expectLint('list2.elementAt(0)')};
7267
}
73-
''',
74-
[lint(36, 18), lint(104, 18), lint(126, 18)],
75-
);
68+
''');
7669
}
7770

7871
void
@@ -90,24 +83,21 @@ var c = list.elementAt(zeroVar);
9083
}
9184

9285
void test_reports_on_iterable_subclasses() async {
93-
await assertDiagnostics(
94-
r'''
86+
await assertAutoDiagnostics('''
9587
abstract class MyIterable<T> implements Iterable<T> {}
9688
9789
T getFirst<T>(MyIterable<T> iterable) {
98-
return iterable.elementAt(0);
90+
return ${expectLint('iterable.elementAt(0)')};
9991
}
10092
10193
void main () {
10294
final set = {0, 1, 2, 3};
10395
final map = {0: 0, 1: 1, 2: 2, 3: 3};
10496
105-
set.elementAt(0);
106-
map.keys.elementAt(0);
107-
map.values.elementAt(0);
97+
${expectLint('set.elementAt(0)')};
98+
${expectLint('map.keys.elementAt(0)')};
99+
${expectLint('map.values.elementAt(0)')};
108100
}
109-
''',
110-
[lint(105, 21), lint(217, 16), lint(237, 21), lint(262, 23)],
111-
);
101+
''');
112102
}
113103
}

0 commit comments

Comments
 (0)