Ld_dict issues we found

[SKernchen]

While testing ld_dict #410 a few things came to notice:

• You can not update with a nested ld_dict or ld_list, only when it is in the ld_container structure with hierarchy.
• The nesting for ld_container with variables is pointing at each other, therefore you have to assign None first.
• The context is only applied on the key side not on the value side
• The context from_dict has to be in the expanded version right now, even though every thing else can be in short form
• Full_context with two of the same context does not bring the same context together, instead it just appends both.
• @context and context in from_dict are not following each other. Only @context is applied.
• rename is_ld_dict to is_expanded_ld_dict

Some of the things are probably by intention because we expect the user to use it properly. But others should at least be discussed. However all the points are important for a higher level class like the api (#432 ).

Please see the FIXME notes in test_ld_dict for more understanding and especially the commit a08eaf2 (a08eaf2) where all these things were showing up.

[notactuallyfinn]

As shown in commit fce1519.
Gettingt a value that is a list (in this case an expanded set) that contains at least one dictionary that is not a value, typed_value or id, an error will occur.
Note that a Python list containing a single dict that is not a typed_value, value or id will not result in an error, as this "list" is considered an expanded json dict.

[SKernchen]

You can not update with a nested ld_dict or ld_list, only when it is in the ld_container structure with hierarchy.

• should be fixed with type conversions in init in mergerequest Implement public API #432

The nesting for ld_container with variables is pointing at each other, therefore you have to assign None first.

• Yes, but as user you mostly use a short dict or nest it directly. So initializing ld_dicts is not really a case.

The context is only applied on the key side not on the value side

• need to be fixed

def test_build_in_set2():
  di = ld_dict([{}], context=[{"schema": "https://schema.org/"}])
  di["@type"] = "schema:Thing"
  di["schema:result"] = {"@type": "schema:Action", "schema:error": {"@type": "schema:Thing", "schema:name": "foo"}}
  assert di.data_dict == {
      "@type": ["https://schema.org/Thing"],
      "https://schema.org/result": [{
          "@type": ["https://schema.org/Action"],
          "https://schema.org/error": [{
              "@type": ["https://schema.org/Thing"],
              "https://schema.org/name": [{"@value": "foo"}]
          }]
      }]
  }

The context from_dict has to be in the expanded version right now, even though every thing else can be in short form

• need to be fixed, because its more useful if it works both ways, test for that:

def test_from_dict2():
    outer_di = di
    di = ld_dict.from_dict({"@context": {"schema": "https://schema.org/"}, "@type": "schema:Action",
                            "schema:name": "foo"},
                           parent=outer_di, key="schema:result")
    assert di.data_dict == {"@type": ["https://schema.org/Action"], "https://schema.org/name": [{"@value": "foo"}]}
    assert di.full_context == 2 * [{"schema": "https://schema.org/"}]
    assert di.context == {"schema": "https://schema.org/"} and di.key == "schema:result" and di.index is None

Full_context with two of the same context does not bring the same context together, instead it just appends both.

• not important right now, because everything works as you think

@context and context in from_dict are not following each other. Only @context is applied.

• need to be fixed

def test_from_dict2():
  di = ld_dict.from_dict({"@context": {"schema": "https://schema.org/"}, "@type": "schema:Thing", "xmlns:name": "fo"},
                             context={"xmlns": "http://xmlns.com/foaf/0.1/"})
  assert di["http://xmlns.com/foaf/0.1/name"] == di["xmlns:name"] == "fo"
  assert di.context == {"schema": "https://schema.org/", "xmlns": "http://xmlns.com/foaf/0.1/"}

rename is_ld_dict to is_expanded_ld_dict

• not import right now