From 7a8931c726897676e9c13df098798aef7521de02 Mon Sep 17 00:00:00 2001 From: Robert Segal Date: Thu, 20 Nov 2025 18:34:08 -0700 Subject: [PATCH 1/2] Added Accounts account by id users endpoints e2e tests --- .flake8 | 5 + e2e_config.test.json | 1 + .../accounts/accounts_user_groups.py | 43 +++- tests/e2e/accounts/accounts_users/conftest.py | 36 ++++ .../test_async_accounts_users.py | 201 ++++++++++++++++++ .../test_sync_accounts_users.py | 193 +++++++++++++++++ tests/e2e/conftest.py | 10 + .../accounts/test_accounts_user_groups.py | 62 +++++- 8 files changed, 545 insertions(+), 6 deletions(-) create mode 100644 .flake8 create mode 100644 tests/e2e/accounts/accounts_users/conftest.py create mode 100644 tests/e2e/accounts/accounts_users/test_async_accounts_users.py create mode 100644 tests/e2e/accounts/accounts_users/test_sync_accounts_users.py diff --git a/.flake8 b/.flake8 new file mode 100644 index 00000000..a6403e6a --- /dev/null +++ b/.flake8 @@ -0,0 +1,5 @@ + +[flake8] +per-file-ignores = + tests/e2e/accounts/accounts_users/test_sync_accounts_users.py: WPS402,WPS421,AAA01 + test_sync_accounts_users.py: WPS402,WPS421,AAA01 diff --git a/e2e_config.test.json b/e2e_config.test.json index 4130e22f..05aaa04d 100644 --- a/e2e_config.test.json +++ b/e2e_config.test.json @@ -9,6 +9,7 @@ "accounts.module.id": "MOD-1756", "accounts.module.name": "Access Management", "accounts.seller.id": "SEL-7310-3075", + "accounts.user.id": "USR-9673-3314", "accounts.user_group.id": "UGR-6822-0561", "catalog.product.item.id": "ITM-7255-3950-0751", "catalog.product.document.id": "PDC-7255-3950-0001", diff --git a/mpt_api_client/resources/accounts/accounts_user_groups.py b/mpt_api_client/resources/accounts/accounts_user_groups.py index 2b17c6c2..1fa1062e 100644 --- a/mpt_api_client/resources/accounts/accounts_user_groups.py +++ b/mpt_api_client/resources/accounts/accounts_user_groups.py @@ -1,11 +1,16 @@ from mpt_api_client.http import AsyncService, Service from mpt_api_client.http.mixins import ( AsyncCollectionMixin, - AsyncManagedResourceMixin, + AsyncCreateMixin, + AsyncDeleteMixin, + AsyncGetMixin, CollectionMixin, - ManagedResourceMixin, + CreateMixin, + DeleteMixin, + GetMixin, ) from mpt_api_client.models import Model +from mpt_api_client.models.model import ResourceData class AccountsUserGroup(Model): @@ -21,18 +26,48 @@ class AccountsUserGroupsServiceConfig: class AccountsUserGroupsService( - ManagedResourceMixin[AccountsUserGroup], + GetMixin[AccountsUserGroup], + CreateMixin[AccountsUserGroup], + DeleteMixin, CollectionMixin[AccountsUserGroup], Service[AccountsUserGroup], AccountsUserGroupsServiceConfig, ): """Account User Groups Service.""" + def update(self, resource_data: ResourceData) -> AccountsUserGroup: + """Update Account User Group. + + Args: + resource_data (ResourceData): Resource data to update. + + Returns: + AccountsUserGroup: Updated Account User Group. + """ + response = self.http_client.request("put", self.path, json=resource_data) + + return self._model_class.from_response(response) + class AsyncAccountsUserGroupsService( - AsyncManagedResourceMixin[AccountsUserGroup], + AsyncGetMixin[AccountsUserGroup], + AsyncCreateMixin[AccountsUserGroup], + AsyncDeleteMixin, AsyncCollectionMixin[AccountsUserGroup], AsyncService[AccountsUserGroup], AccountsUserGroupsServiceConfig, ): """Asynchronous Account User Groups Service.""" + + async def update(self, resource_data: ResourceData) -> AccountsUserGroup: + """Update Account User Group. + + Args: + resource_data (ResourceData): Resource data to update. + + Returns: + AccountsUserGroup: Updated Account User Group. + """ + response = await self.http_client.request("put", self.path, json=resource_data) + + return self._model_class.from_response(response) diff --git a/tests/e2e/accounts/accounts_users/conftest.py b/tests/e2e/accounts/accounts_users/conftest.py new file mode 100644 index 00000000..689d37f5 --- /dev/null +++ b/tests/e2e/accounts/accounts_users/conftest.py @@ -0,0 +1,36 @@ +import pytest + + +@pytest.fixture +def invalid_user_id(): + return "USR-0000-0000" + + +@pytest.fixture +def account_user_factory(account_id, user_group_id, uuid_str): + def _account_user( # noqa: WPS430 + email: str | None = None, # Must be unique in Marketplace + first_name: str = "E2E Created", + last_name: str = "Account User", + ): + if not email: + email = f"e2e_{uuid_str}@dummy.com" + + return { + "user": { + "firstName": first_name, + "lastName": last_name, + "email": email, + }, + "account": { + "id": account_id, + }, + "groups": [ + {"id": user_group_id}, + ], + "invitation": { + "status": "Invited", + }, + } + + return _account_user diff --git a/tests/e2e/accounts/accounts_users/test_async_accounts_users.py b/tests/e2e/accounts/accounts_users/test_async_accounts_users.py new file mode 100644 index 00000000..086c9948 --- /dev/null +++ b/tests/e2e/accounts/accounts_users/test_async_accounts_users.py @@ -0,0 +1,201 @@ +# noqa: WPS204, WPS420, WPS421, WPS210, AAA01 +# noqa: WPS402 +import pytest + +from mpt_api_client.exceptions import MPTAPIError +from mpt_api_client.rql.query_builder import RQLQuery + +pytestmark = [pytest.mark.flaky] + + +@pytest.fixture +def users(async_mpt_vendor, account_id): + return async_mpt_vendor.accounts.accounts.users(account_id=account_id) # noqa: WPS204 + + +@pytest.fixture +async def created_account_user(async_mpt_vendor, account_user_factory, account_id): + """Fixture to create and teardown an account user.""" + ret_account_user = None + + async def _created_account_user( + first_name: str = "E2E Created", + last_name: str = "Account User", + ): + """Create an account user with the given first and last name.""" + nonlocal ret_account_user # noqa: WPS420 + account_user_data = account_user_factory( + first_name=first_name, + last_name=last_name, + ) + users_obj = async_mpt_vendor.accounts.accounts.users(account_id=account_id) + ret_account_user = await users_obj.create(account_user_data) + return ret_account_user + + yield _created_account_user + + if ret_account_user: + users_obj = async_mpt_vendor.accounts.accounts.users(account_id=account_id) + try: + await users_obj.delete(ret_account_user.id) + except MPTAPIError as error: + print( # noqa: WPS421 + f"TEARDOWN - Unable to delete account user {ret_account_user.id}: " + f"{getattr(error, 'title', str(error))}" + ) + + +@pytest.fixture +async def created_user_group(async_mpt_ops, user_group_factory): + """Fixture to create and teardown a user group.""" + new_user_group_request_data = user_group_factory() + created_user_group = await async_mpt_ops.accounts.user_groups.create( + new_user_group_request_data + ) + + yield created_user_group + + try: + await async_mpt_ops.accounts.user_groups.delete(created_user_group.id) + except MPTAPIError as error: + print(f"TEARDOWN - Unable to delete user group: {getattr(error, 'title', str(error))}") # noqa: WPS421 + + +@pytest.fixture +async def created_account_user_group( # noqa: WPS210 + async_mpt_vendor, created_account_user, created_user_group, account_id +): + """Fixture to create and teardown an account user group.""" + created_account_user_data = await created_account_user() + user_group_data = created_user_group + create_user_group_data = {"id": user_group_data.id} + users = async_mpt_vendor.accounts.accounts.users(account_id=account_id) + created_account_user_group = await users.groups(user_id=created_account_user_data.id).create( + create_user_group_data + ) + yield created_account_user_group + + users_obj = async_mpt_vendor.accounts.accounts.users(account_id=account_id) + try: + await users_obj.groups(user_id=created_account_user_data.id).delete(user_group_data.id) + except MPTAPIError as error: + print( # noqa: WPS421 + f"TEARDOWN - Unable to delete account user group: {getattr(error, 'title', str(error))}" + ) + + +async def test_get_account_user_by_id(async_mpt_vendor, user_id, account_id): + """Test retrieving an account user by ID.""" + users_obj = async_mpt_vendor.accounts.accounts.users(account_id=account_id) + account_user = await users_obj.get(user_id) + assert account_user is not None + + +async def test_list_account_users(async_mpt_vendor, account_id): + """Test listing account users.""" + limit = 10 + + users_obj = async_mpt_vendor.accounts.accounts.users(account_id=account_id) + account_users = await users_obj.fetch_page(limit=limit) + + assert len(account_users) > 0 + + +async def test_get_account_user_by_id_not_found(async_mpt_vendor, invalid_user_id, account_id): + """Test retrieving an account user by invalid ID.""" + users_obj = async_mpt_vendor.accounts.accounts.users(account_id=account_id) + + with pytest.raises(MPTAPIError, match=r"404 Not Found"): + await users_obj.get(invalid_user_id) + + +async def test_filter_account_users(async_mpt_vendor, user_id, account_id): + """Test filtering account users.""" + select_fields = ["-name"] + + users_obj = async_mpt_vendor.accounts.accounts.users(account_id=account_id) + filtered_account_users = users_obj.filter(RQLQuery(id=user_id)).select(*select_fields) + account_users = [user async for user in filtered_account_users.iterate()] + + assert len(account_users) == 1 + + +async def test_create_account_user(created_account_user): + """Test creating an account user.""" + account_user_data = await created_account_user() + assert account_user_data is not None + + +async def test_delete_account_user(async_mpt_vendor, created_account_user, account_id): + """Test deleting an account user.""" + account_user_data = await created_account_user() + users_obj = async_mpt_vendor.accounts.accounts.users(account_id=account_id) + await users_obj.delete(account_user_data.id) + + +async def test_update_account_user( + async_mpt_vendor, + account_user_factory, + created_account_user, + account_id, +): + """Test updating an account user.""" + account_user_data = await created_account_user() + users_obj = async_mpt_vendor.accounts.accounts.users(account_id=account_id) + updated_account_user_data = account_user_factory( + first_name="E2E Updated", + last_name="Account User", + ) + updated_account_user = await users_obj.update( + account_user_data.id, + updated_account_user_data, + ) + assert updated_account_user is not None + + +async def test_account_user_resend_invite( + async_mpt_vendor, + created_account_user, + account_id, +): + """Test resending an invite to an account user.""" + account_user_data = await created_account_user() + users_obj = async_mpt_vendor.accounts.accounts.users(account_id=account_id) + resend_invite = await users_obj.resend_invite(account_user_data.id) + assert resend_invite is not None + + +def test_account_user_group_post(created_account_user_group): # noqa: AAA01 + """Test creating an account user group.""" + created_account_user_group_data = created_account_user_group + assert created_account_user_group_data is not None + + +async def test_account_user_group_update( + async_mpt_vendor, + created_account_user, + created_user_group, + account_id, +): + """Test updating an account user group.""" + created_account_user_data = await created_account_user() + users_obj = async_mpt_vendor.accounts.accounts.users(account_id=account_id) + update_user_group_data = [{"id": created_user_group.id}] + updated_account_user_group = await users_obj.groups( + user_id=created_account_user_data.id + ).update(update_user_group_data) + assert updated_account_user_group is not None + + +async def test_account_user_group_delete( + async_mpt_vendor, + created_account_user, + created_user_group, + account_id, +): + """Test deleting an account user group.""" + created_account_user_data = await created_account_user() + users_obj = async_mpt_vendor.accounts.accounts.users(account_id=account_id) + create_user_group_data = {"id": created_user_group.id} + await users_obj.groups(user_id=created_account_user_data.id).create(create_user_group_data) + await users_obj.groups(user_id=created_account_user_data.id).delete(created_user_group.id) diff --git a/tests/e2e/accounts/accounts_users/test_sync_accounts_users.py b/tests/e2e/accounts/accounts_users/test_sync_accounts_users.py new file mode 100644 index 00000000..eaf87c21 --- /dev/null +++ b/tests/e2e/accounts/accounts_users/test_sync_accounts_users.py @@ -0,0 +1,193 @@ +# noqa: WPS402 +import pytest + +from mpt_api_client.exceptions import MPTAPIError +from mpt_api_client.rql.query_builder import RQLQuery + +pytestmark = [pytest.mark.flaky] + + +@pytest.fixture +def users(mpt_vendor, account_id): # noqa: WPS204 + return mpt_vendor.accounts.accounts.users(account_id=account_id) # noqa: WPS204 + + +@pytest.fixture +def created_account_user(mpt_vendor, account_user_factory, account_id): + """Fixture to create and teardown an account user.""" + ret_account_user = None + + def _created_account_user( + first_name: str = "E2E Created", + last_name: str = "Account User", + ): + """Create an account user with the given first and last name.""" + nonlocal ret_account_user # noqa: WPS420 + account_user_data = account_user_factory( + first_name=first_name, + last_name=last_name, + ) + users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) + ret_account_user = users_obj.create(account_user_data) + return ret_account_user + + yield _created_account_user + + if ret_account_user: + users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) + try: + users_obj.delete(ret_account_user.id) + except MPTAPIError: + print( # noqa: WPS421 + f"TEARDOWN - Unable to delete account user {ret_account_user.id}", + ) + + +@pytest.fixture +def created_user_group(mpt_ops, user_group_factory): + """Fixture to create and teardown a user group.""" + new_user_group_request_data = user_group_factory() + created_user_group = mpt_ops.accounts.user_groups.create(new_user_group_request_data) + + yield created_user_group + + try: + mpt_ops.accounts.user_groups.delete(created_user_group.id) + except MPTAPIError as error: + print(f"TEARDOWN - Unable to delete user group: {error.title}") # noqa: WPS421 + + +@pytest.fixture +def created_account_user_group(mpt_vendor, created_account_user, created_user_group, account_id): # noqa: WPS210 + """Fixture to create and teardown an account user group.""" + created_account_user_data = created_account_user() + user_group_data = created_user_group + create_user_group_data = {"id": user_group_data.id} + users = mpt_vendor.accounts.accounts.users(account_id=account_id) + created_account_user_group = users.groups(user_id=created_account_user_data.id).create( + create_user_group_data + ) + yield created_account_user_group + + users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) + try: + users_obj.groups(user_id=created_account_user_data.id).delete(user_group_data.id) + except MPTAPIError as error: + print(f"TEARDOWN - Unable to delete account user group: {error.title}") # noqa: WPS421 + + +def test_get_account_user_by_id(mpt_vendor, user_id, account_id): # noqa: AAA01 + """Test retrieving an account user by ID.""" + users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) + account_user = users_obj.get(user_id) + assert account_user is not None + + +def test_list_account_users(mpt_vendor, account_id): # noqa: AAA01 + """Test listing account users.""" + limit = 10 + + users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) + account_users = users_obj.fetch_page(limit=limit) + + assert len(account_users) > 0 + + +def test_get_account_user_by_id_not_found(mpt_vendor, invalid_user_id, account_id): + """Test retrieving an account user by invalid ID.""" + users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) + + with pytest.raises(MPTAPIError, match=r"404 Not Found"): + users_obj.get(invalid_user_id) + + +def test_filter_account_users(mpt_vendor, user_id, account_id): # noqa: AAA01 + """Test filtering account users.""" + select_fields = ["-name"] + + users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) + filtered_account_users = users_obj.filter(RQLQuery(id=user_id)).select(*select_fields) + account_users = list(filtered_account_users.iterate()) + + assert len(account_users) == 1 + + +def test_create_account_user(created_account_user): # noqa: AAA01 + """Test creating an account user.""" + account_user_data = created_account_user() + assert account_user_data is not None + + +def test_delete_account_user(mpt_vendor, created_account_user, account_id): # noqa: AAA01 + """Test deleting an account user.""" + account_user_data = created_account_user() + users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) + users_obj.delete(account_user_data.id) + + +def test_update_account_user( # noqa: AAA01 + mpt_vendor, + account_user_factory, + created_account_user, + account_id, +): + """Test updating an account user.""" + account_user_data = created_account_user() + users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) + updated_account_user_data = account_user_factory( + first_name="E2E Updated", + last_name="Account User", + ) + updated_account_user = users_obj.update( + account_user_data.id, + updated_account_user_data, + ) + assert updated_account_user is not None + + +def test_account_user_resend_invite( # noqa: AAA01 + mpt_vendor, + created_account_user, + account_id, +): + """Test resending an invite to an account user.""" + account_user_data = created_account_user() + users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) + resend_invite = users_obj.resend_invite(account_user_data.id) + assert resend_invite is not None + + +def test_account_user_group_post(created_account_user_group): # noqa: AAA01 + """Test creating an account user group.""" + created_account_user_group_data = created_account_user_group + assert created_account_user_group_data is not None + + +def test_account_user_group_update( # noqa: AAA01 + mpt_vendor, + created_account_user, + created_user_group, + account_id, +): + """Test updating an account user group.""" + created_account_user_data = created_account_user() + users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) + update_user_group_data = [{"id": created_user_group.id}] + updated_account_user_group = users_obj.groups(user_id=created_account_user_data.id).update( + update_user_group_data + ) + assert updated_account_user_group is not None + + +def test_account_user_group_delete( # noqa: AAA01 + mpt_vendor, + created_account_user, + created_user_group, + account_id, +): + """Test deleting an account user group.""" + created_account_user_data = created_account_user() + users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) + create_user_group_data = {"id": created_user_group.id} + users_obj.groups(user_id=created_account_user_data.id).create(create_user_group_data) + users_obj.groups(user_id=created_account_user_data.id).delete(created_user_group.id) diff --git a/tests/e2e/conftest.py b/tests/e2e/conftest.py index c2f83c79..0bea87e7 100644 --- a/tests/e2e/conftest.py +++ b/tests/e2e/conftest.py @@ -102,7 +102,17 @@ def short_uuid(): return uuid.uuid4().hex[:8] +@pytest.fixture +def uuid_str(): + return str(uuid.uuid4()) + + @pytest.fixture def logo_fd(): file_path = pathlib.Path(__file__).parent / "logo.png" return pathlib.Path.open(file_path, "rb") + + +@pytest.fixture +def user_id(e2e_config): + return e2e_config["accounts.user.id"] diff --git a/tests/unit/resources/accounts/test_accounts_user_groups.py b/tests/unit/resources/accounts/test_accounts_user_groups.py index 5537eb9d..f7b68909 100644 --- a/tests/unit/resources/accounts/test_accounts_user_groups.py +++ b/tests/unit/resources/accounts/test_accounts_user_groups.py @@ -1,4 +1,8 @@ +import json + +import httpx import pytest +import respx from mpt_api_client.resources.accounts.accounts_user_groups import ( AccountsUserGroupsService, @@ -42,7 +46,7 @@ def test_async_endpoint(async_accounts_user_groups_service): @pytest.mark.parametrize( "method", - ["create", "update", "delete"], + ["create", "delete"], ) def test_mixins_present(accounts_user_groups_service, method): result = hasattr(accounts_user_groups_service, method) @@ -52,9 +56,63 @@ def test_mixins_present(accounts_user_groups_service, method): @pytest.mark.parametrize( "method", - ["create", "update", "delete"], + ["create", "delete"], ) def test_async_mixins_present(async_accounts_user_groups_service, method): result = hasattr(async_accounts_user_groups_service, method) assert result is True + + +def test_account_user_groups_update(accounts_user_groups_service): # noqa: AAA01 + """Test updating account user groups.""" + group_id = "GRP-0000-0001" + user_id = "USR-0000-0001" + input_data = [{"id": group_id}] + request_expected_content = json.dumps(input_data, separators=(",", ":")).encode() + response_expected_data = {"id": group_id, "name": "Test Group"} + + with respx.mock: + mock_route = respx.put( + f"https://api.example.com/public/v1/accounts/ACC-0000-0001/users/{user_id}/groups" + ).mock( + return_value=httpx.Response( + status_code=httpx.codes.OK, + headers={"content-type": "application/json"}, + json=response_expected_data, + ) + ) + + updated_group = accounts_user_groups_service.update(input_data) + + assert mock_route.call_count == 1 + request = mock_route.calls[0].request + assert request.content == request_expected_content + assert updated_group.to_dict() == response_expected_data + + +async def test_async_account_user_groups_update(async_accounts_user_groups_service): + """Test updating account user groups asynchronously.""" + group_id = "GRP-0000-0001" + user_id = "USR-0000-0001" + input_data = [{"id": group_id}] + request_expected_content = json.dumps(input_data, separators=(",", ":")).encode() + response_expected_data = {"id": group_id, "name": "Test Group"} + + with respx.mock: + mock_route = respx.put( + f"https://api.example.com/public/v1/accounts/ACC-0000-0001/users/{user_id}/groups" + ).mock( + return_value=httpx.Response( + status_code=httpx.codes.OK, + headers={"content-type": "application/json"}, + json=response_expected_data, + ) + ) + + updated_group = await async_accounts_user_groups_service.update(input_data) + + assert mock_route.call_count == 1 + request = mock_route.calls[0].request + assert request.content == request_expected_content + assert updated_group.to_dict() == response_expected_data From 5e7e3c214139c619af0bbb3c9ebf0d9fc4e96fb2 Mon Sep 17 00:00:00 2001 From: Albert Sola Date: Thu, 27 Nov 2025 16:43:13 +0000 Subject: [PATCH 2/2] Fix tests --- .flake8 | 5 -- .github/workflows/pr-build-merge.yml | 3 +- .../test_async_accounts_users.py | 2 - .../test_sync_accounts_users.py | 80 +++++++++++-------- 4 files changed, 47 insertions(+), 43 deletions(-) delete mode 100644 .flake8 diff --git a/.flake8 b/.flake8 deleted file mode 100644 index a6403e6a..00000000 --- a/.flake8 +++ /dev/null @@ -1,5 +0,0 @@ - -[flake8] -per-file-ignores = - tests/e2e/accounts/accounts_users/test_sync_accounts_users.py: WPS402,WPS421,AAA01 - test_sync_accounts_users.py: WPS402,WPS421,AAA01 diff --git a/.github/workflows/pr-build-merge.yml b/.github/workflows/pr-build-merge.yml index 22ea8b9c..5e89141a 100644 --- a/.github/workflows/pr-build-merge.yml +++ b/.github/workflows/pr-build-merge.yml @@ -41,7 +41,8 @@ jobs: run: docker compose run --service-ports app_test - name: "Run E2E test" - run: docker compose run --service-ports e2e bash -c "pytest -v -p no:randomly --no-cov --reportportal --rp-launch=$RP_LAUNCH --rp-api-key=$RP_API_KEY --rp-endpoint=$RP_ENDPOINT --junitxml=e2e-report.xml tests/e2e" + #run: docker compose run --service-ports e2e bash -c "pytest -v -p no:randomly --no-cov --reportportal --rp-launch=$RP_LAUNCH --rp-api-key=$RP_API_KEY --rp-endpoint=$RP_ENDPOINT --junitxml=e2e-report.xml tests/e2e" + run: docker compose run --service-ports e2e bash -c "pytest -v -p no:randomly --no-cov --junitxml=e2e-report.xml tests/e2e" env: RP_LAUNCH: github-e2e-test RP_ENDPOINT: ${{ secrets.RP_ENDPOINT }} diff --git a/tests/e2e/accounts/accounts_users/test_async_accounts_users.py b/tests/e2e/accounts/accounts_users/test_async_accounts_users.py index 086c9948..1c66c754 100644 --- a/tests/e2e/accounts/accounts_users/test_async_accounts_users.py +++ b/tests/e2e/accounts/accounts_users/test_async_accounts_users.py @@ -1,5 +1,3 @@ -# noqa: WPS204, WPS420, WPS421, WPS210, AAA01 -# noqa: WPS402 import pytest from mpt_api_client.exceptions import MPTAPIError diff --git a/tests/e2e/accounts/accounts_users/test_sync_accounts_users.py b/tests/e2e/accounts/accounts_users/test_sync_accounts_users.py index eaf87c21..a107adb4 100644 --- a/tests/e2e/accounts/accounts_users/test_sync_accounts_users.py +++ b/tests/e2e/accounts/accounts_users/test_sync_accounts_users.py @@ -1,4 +1,3 @@ -# noqa: WPS402 import pytest from mpt_api_client.exceptions import MPTAPIError @@ -8,7 +7,7 @@ @pytest.fixture -def users(mpt_vendor, account_id): # noqa: WPS204 +def users(mpt_vendor, account_id): return mpt_vendor.accounts.accounts.users(account_id=account_id) # noqa: WPS204 @@ -76,21 +75,23 @@ def created_account_user_group(mpt_vendor, created_account_user, created_user_gr print(f"TEARDOWN - Unable to delete account user group: {error.title}") # noqa: WPS421 -def test_get_account_user_by_id(mpt_vendor, user_id, account_id): # noqa: AAA01 +def test_get_account_user_by_id(mpt_vendor, user_id, account_id): """Test retrieving an account user by ID.""" users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) - account_user = users_obj.get(user_id) - assert account_user is not None + result = users_obj.get(user_id) -def test_list_account_users(mpt_vendor, account_id): # noqa: AAA01 + assert result is not None + + +def test_list_account_users(mpt_vendor, account_id): """Test listing account users.""" limit = 10 - users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) - account_users = users_obj.fetch_page(limit=limit) - assert len(account_users) > 0 + result = users_obj.fetch_page(limit=limit) + + assert len(result) > 0 def test_get_account_user_by_id_not_found(mpt_vendor, invalid_user_id, account_id): @@ -101,31 +102,34 @@ def test_get_account_user_by_id_not_found(mpt_vendor, invalid_user_id, account_i users_obj.get(invalid_user_id) -def test_filter_account_users(mpt_vendor, user_id, account_id): # noqa: AAA01 +def test_filter_account_users(mpt_vendor, user_id, account_id): """Test filtering account users.""" select_fields = ["-name"] - users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) filtered_account_users = users_obj.filter(RQLQuery(id=user_id)).select(*select_fields) - account_users = list(filtered_account_users.iterate()) - assert len(account_users) == 1 + result = list(filtered_account_users.iterate()) + assert len(result) == 1 -def test_create_account_user(created_account_user): # noqa: AAA01 + +def test_create_account_user(created_account_user): """Test creating an account user.""" - account_user_data = created_account_user() - assert account_user_data is not None + result = created_account_user() + + assert result is not None -def test_delete_account_user(mpt_vendor, created_account_user, account_id): # noqa: AAA01 +def test_delete_account_user(mpt_vendor, created_account_user, account_id): """Test deleting an account user.""" account_user_data = created_account_user() - users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) - users_obj.delete(account_user_data.id) + result = mpt_vendor.accounts.accounts.users(account_id=account_id) + + result.delete(account_user_data.id) -def test_update_account_user( # noqa: AAA01 + +def test_update_account_user( mpt_vendor, account_user_factory, created_account_user, @@ -138,14 +142,16 @@ def test_update_account_user( # noqa: AAA01 first_name="E2E Updated", last_name="Account User", ) - updated_account_user = users_obj.update( + + result = users_obj.update( account_user_data.id, updated_account_user_data, ) - assert updated_account_user is not None + + assert result is not None -def test_account_user_resend_invite( # noqa: AAA01 +def test_account_user_resend_invite( mpt_vendor, created_account_user, account_id, @@ -153,17 +159,20 @@ def test_account_user_resend_invite( # noqa: AAA01 """Test resending an invite to an account user.""" account_user_data = created_account_user() users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) - resend_invite = users_obj.resend_invite(account_user_data.id) - assert resend_invite is not None + + result = users_obj.resend_invite(account_user_data.id) + + assert result is not None -def test_account_user_group_post(created_account_user_group): # noqa: AAA01 +def test_account_user_group_post(created_account_user_group): """Test creating an account user group.""" - created_account_user_group_data = created_account_user_group - assert created_account_user_group_data is not None + result = created_account_user_group + assert result is not None -def test_account_user_group_update( # noqa: AAA01 + +def test_account_user_group_update( mpt_vendor, created_account_user, created_user_group, @@ -173,13 +182,13 @@ def test_account_user_group_update( # noqa: AAA01 created_account_user_data = created_account_user() users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) update_user_group_data = [{"id": created_user_group.id}] - updated_account_user_group = users_obj.groups(user_id=created_account_user_data.id).update( - update_user_group_data - ) - assert updated_account_user_group is not None + result = users_obj.groups(user_id=created_account_user_data.id).update(update_user_group_data) + + assert result is not None -def test_account_user_group_delete( # noqa: AAA01 + +def test_account_user_group_delete( mpt_vendor, created_account_user, created_user_group, @@ -190,4 +199,5 @@ def test_account_user_group_delete( # noqa: AAA01 users_obj = mpt_vendor.accounts.accounts.users(account_id=account_id) create_user_group_data = {"id": created_user_group.id} users_obj.groups(user_id=created_account_user_data.id).create(create_user_group_data) - users_obj.groups(user_id=created_account_user_data.id).delete(created_user_group.id) + + users_obj.groups(user_id=created_account_user_data.id).delete(created_user_group.id) # act