Skip to content

fix: use PREVIOUS_VERSION_TAG for OCR and TTS URLs #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msluszniak merged 1 commit into from
May 27, 2026
Merged

fix: use PREVIOUS_VERSION_TAG for OCR and TTS URLs #1191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/react-native-executorch/src/constants/ocr/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { alphabets, symbols } from './symbols';

import { URL_PREFIX, VERSION_TAG } from '../versions';
import { URL_PREFIX, PREVIOUS_VERSION_TAG } from '../versions';

const DETECTOR_CRAFT_MODEL = `${URL_PREFIX}-detector-craft/${VERSION_TAG}/xnnpack/craft_xnnpack_int8.pte`;
const DETECTOR_CRAFT_MODEL = `${URL_PREFIX}-detector-craft/${PREVIOUS_VERSION_TAG}/xnnpack/craft_xnnpack_int8.pte`;

const createHFRecognizerDownloadUrl = (alphabet: keyof typeof alphabets) =>
`${URL_PREFIX}-recognizer-crnn.en/${VERSION_TAG}/${alphabet}/xnnpack/crnn_${alphabet}_xnnpack_fp32.pte`;
`${URL_PREFIX}-recognizer-crnn.en/${PREVIOUS_VERSION_TAG}/${alphabet}/xnnpack/crnn_${alphabet}_xnnpack_fp32.pte`;

const RECOGNIZER_ENGLISH_CRNN = createHFRecognizerDownloadUrl('english');
const RECOGNIZER_LATIN_CRNN = createHFRecognizerDownloadUrl('latin');
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native-executorch/src/constants/tts/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { URL_PREFIX, VERSION_TAG } from '../versions';
import { URL_PREFIX, PREVIOUS_VERSION_TAG } from '../versions';

// Text to speech (tts) - Kokoro model(s)
const KOKORO_MODEL_ROOT = `${URL_PREFIX}-kokoro/${VERSION_TAG}/xnnpack`;
const KOKORO_MODEL_ROOT = `${URL_PREFIX}-kokoro/${PREVIOUS_VERSION_TAG}/xnnpack`;
const KOKORO_STANDARD_MODEL_ROOT = `${KOKORO_MODEL_ROOT}/standard`;
const KOKORO_POLISH_MODEL_ROOT = `${KOKORO_MODEL_ROOT}/polish`;
const KOKORO_GERMAN_MODEL_ROOT = `${KOKORO_MODEL_ROOT}/german`;
Expand Down
6 changes: 3 additions & 3 deletions packages/react-native-executorch/src/constants/tts/voices.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { TextToSpeechModelConfig } from '../../types/tts';
import { VERSION_TAG, URL_PREFIX } from '../versions';
import { PREVIOUS_VERSION_TAG, URL_PREFIX } from '../versions';
import { KOKORO_STANDARD, KOKORO_POLISH, KOKORO_GERMAN } from './models';

// Common prefixes - voices & phonemization data
const KOKORO_VOICE_PREFIX = `${URL_PREFIX}-kokoro/${VERSION_TAG}/voices`;
const KOKORO_PHONEMIZER_PREFIX = `${URL_PREFIX}-kokoro/${VERSION_TAG}/phonemizer`;
const KOKORO_VOICE_PREFIX = `${URL_PREFIX}-kokoro/${PREVIOUS_VERSION_TAG}/voices`;
const KOKORO_PHONEMIZER_PREFIX = `${URL_PREFIX}-kokoro/${PREVIOUS_VERSION_TAG}/phonemizer`;

const KOKORO_PHONEMIZER_EN_US_PREFIX = `${KOKORO_PHONEMIZER_PREFIX}/en-us`;
const KOKORO_PHONEMIZER_EN_US_TAGGER = `${KOKORO_PHONEMIZER_EN_US_PREFIX}/tags.json`;
Expand Down
Loading