Merge pull request #2 from soficis/copilot/sub-pr-1

[WIP] Update build system and refactor controller based on feedback

Author: soficis

src/domain/JsonSerialization.cpp

@@ -2,6 +2,8 @@
 
 #include <algorithm>
 
+#include "domain/ProjectProfile.h"
+
 namespace automix::domain {
 
 void to_json(Json& j, const Stem& value) {
@@ -293,7 +295,7 @@ void from_json(const Json& j, Session& value) {
   value.buses = j.value("buses", std::vector<Bus>{});
   value.projectProfileId = j.value("projectProfileId", "default");
   value.safetyPolicyId = j.value("safetyPolicyId", "balanced");
-  value.preferredStemCount = std::clamp(j.value("preferredStemCount", 4), 2, 6);
+  value.preferredStemCount = std::clamp(j.value("preferredStemCount", 4), kMinPreferredStemCount, kMaxPreferredStemCount);
 
   const auto timelineJson = j.value("timeline", Json::object());
   value.timeline.loopEnabled = timelineJson.value("loopEnabled", false);

src/domain/ProjectProfile.cpp

@@ -24,7 +24,7 @@ ProjectProfile profileFromJson(const nlohmann::json& json) {
   profile.mixModelPackId = json.value("mixModelPackId", "none");
   profile.masterModelPackId = json.value("masterModelPackId", "none");
   profile.safetyPolicyId = json.value("safetyPolicyId", "balanced");
-  profile.preferredStemCount = std::clamp(json.value("preferredStemCount", 4), 2, 6);
+  profile.preferredStemCount = std::clamp(json.value("preferredStemCount", 4), kMinPreferredStemCount, kMaxPreferredStemCount);
   profile.metadataPolicy = json.value("metadataPolicy", "copy_common");
   if (profile.metadataPolicy != "copy_all" &&
       profile.metadataPolicy != "copy_common" &&

src/domain/ProjectProfile.h

@@ -8,6 +8,12 @@
 
 namespace automix::domain {
 
+// Stem count constraints for audio separation.
+// Maximum of 6 stems is based on common separation models (vocals, drums, bass, guitar, keys, other)
+// and practical UI/performance limits for real-time mixing workflows.
+constexpr int kMinPreferredStemCount = 2;
+constexpr int kMaxPreferredStemCount = 6;
+
 struct ProjectProfile {
   std::string id;
   std::string name;

tools/commands/DevToolsUtils.cpp

@@ -693,7 +693,7 @@ std::optional<automix::domain::ProjectProfile> projectProfileFromJson(const nloh
   profile.mixModelPackId = json.value("mixModelPackId", "none");
   profile.masterModelPackId = json.value("masterModelPackId", "none");
   profile.safetyPolicyId = json.value("safetyPolicyId", "balanced");
-  profile.preferredStemCount = std::clamp(json.value("preferredStemCount", 4), 2, 6);
+  profile.preferredStemCount = std::clamp(json.value("preferredStemCount", 4), kMinPreferredStemCount, kMaxPreferredStemCount);
   profile.metadataPolicy = json.value("metadataPolicy", "copy_common");
   if (profile.metadataPolicy != "copy_all" &&
       profile.metadataPolicy != "copy_common" &&