See stratis-storage/stratis-cli#1273
Mulhern writes:
"Since our zbus refactoring was merged, the possibility that any of these methods might raise a DbusClientMissingPropertyError has gone from infinitely small to small."
Additionally:
"the .search() methods that are used to locate specific filesystems can also fail with the related exception dbus_client_gen.DbusClientMissingSearchPropertiesError if one of the items in the result is missing the property that needs to be matched.
I believe that in our case the probability that our search properties will go missing is very very small, because we generally search on Name or Uuid which it is hard for our implementation to not know for any filesystem or pool. The snapm probability may be a little higher, since you search on Origin and MergeScheduled in one case, but it is not very much higher, because without an actual bug in stratisd, we will have that sorted out also."
We should wrap all explicit MOPool / MOFilesystem access in except DbusClientMissingPropertyError and additionally review our .search() method use to understand whether we ought to be catching these exceptions there too.
See stratis-storage/stratis-cli#1273
Mulhern writes:
"Since our zbus refactoring was merged, the possibility that any of these methods might raise a DbusClientMissingPropertyError has gone from infinitely small to small."
Additionally:
"the .search() methods that are used to locate specific filesystems can also fail with the related exception dbus_client_gen.DbusClientMissingSearchPropertiesError if one of the items in the result is missing the property that needs to be matched.
I believe that in our case the probability that our search properties will go missing is very very small, because we generally search on Name or Uuid which it is hard for our implementation to not know for any filesystem or pool. The snapm probability may be a little higher, since you search on Origin and MergeScheduled in one case, but it is not very much higher, because without an actual bug in stratisd, we will have that sorted out also."
We should wrap all explicit
MOPool/MOFilesystemaccess inexcept DbusClientMissingPropertyErrorand additionally review our.search()method use to understand whether we ought to be catching these exceptions there too.