fix in smartsupp variables

Author: marekgach

src/Smartsupp/ChatGenerator.php

@@ -362,6 +362,7 @@ public function render($print_out = false)
         }
 
         $params = array();
+        $params2 = array();
 
         // set cookie domain if not blank
         if ($this->cookie_domain) {
@@ -388,11 +389,11 @@ public function render($print_out = false)
         // set detailed visitor's info
         // basic info
         if ($this->email) {
-            $params[] = "smartsupp('email', '" . self::javascriptEscape($this->email) . "');";
+            $params2[] = "smartsupp('email', '" . self::javascriptEscape($this->email) . "');";
         }
 
         if ($this->name) {
-            $params[] = "smartsupp('name', '" . self::javascriptEscape($this->name) . "');";
+            $params2[] = "smartsupp('name', '" . self::javascriptEscape($this->name) . "');";
         }
 
 
@@ -406,7 +407,7 @@ public function render($print_out = false)
                     "'}";
             }
 
-            $params[] = "smartsupp('variables', {" .
+            $params2[] = "smartsupp('variables', {" .
                 implode(", ", $options) .
             "});";
         }
@@ -442,7 +443,8 @@ public function render($print_out = false)
                 s=d.getElementsByTagName('script')[0];c=d.createElement('script');
                 c.type='text/javascript';c.charset='utf-8';c.async=true;
                 c.src='//www.smartsuppchat.com/loader.js';s.parentNode.insertBefore(c,s);
-            })(document);
+            })(document);"
+            . implode("\n", $params2) . "
             </script>";
 
         $code = str_replace('%key%', self::javascriptEscape($this->key), $code);

tests/ChatGeneratorTest.php

@@ -256,9 +256,6 @@ public function test_render_allParams()
 _smartsupp.offsetX = 20;    // offset from left or right, default 10
 _smartsupp.offsetY = 120;    // offset from top, default 100
 _smartsupp.widget = 'button'; // by default 'widget'
-smartsupp('email', 'johny\\x40depp\\x2ecom');
-smartsupp('name', 'Johny\\x20Depp');
-smartsupp('variables', {orderTotal: {label: 'Total\\x20orders', value: '150'}, lastOrder: {label: 'Last\\x20ordered', value: '2015\\x2d07\\x2d09'}});
 _smartsupp.gaKey = 'UA\\x2d123456';
 _smartsupp.gaOptions = {'cookieDomain': '\\x2efoo\\x2ebar'};
 _smartsupp.hideWidget = true;
@@ -267,7 +264,9 @@ public function test_render_allParams()
                 s=d.getElementsByTagName('script')[0];c=d.createElement('script');
                 c.type='text/javascript';c.charset='utf-8';c.async=true;
                 c.src='//www.smartsuppchat.com/loader.js';s.parentNode.insertBefore(c,s);
-            })(document);
+            })(document);smartsupp('email', 'johny\\x40depp\\x2ecom');
+smartsupp('name', 'Johny\\x20Depp');
+smartsupp('variables', {orderTotal: {label: 'Total\\x20orders', value: '150'}, lastOrder: {label: 'Last\\x20ordered', value: '2015\\x2d07\\x2d09'}});
             </script>";
 
         $ret = $this->chat->render();