From bbf8e612303b5519f400a5bc70a11e63d0183ad1 Mon Sep 17 00:00:00 2001 From: Iva Brajer Date: Thu, 19 Dec 2024 08:58:59 +0100 Subject: [PATCH] Unit test to confirm equality for two Workflow ID generate functions --- pkg/workflows/utils_test.go | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/pkg/workflows/utils_test.go b/pkg/workflows/utils_test.go index 477807733b..97f5f9ed98 100644 --- a/pkg/workflows/utils_test.go +++ b/pkg/workflows/utils_test.go @@ -66,3 +66,23 @@ func Test_GenerateWorkflowIDFromStrings(t *testing.T) { _, err = GenerateWorkflowIDFromStrings(owner, "porporpore", []byte("workflow"), []byte("config"), "http://mysecrets.com") assert.ErrorContains(t, err, "encoding/hex") } + +func Test_GenerateFromStringOrBytesReturnsEqualResult(t *testing.T) { + ownerHex := "26729408f179371be6433b9585d8427f121bfe82" + name := "someRandomWorkflowName" + binary := []byte("binary goes here") + config := []byte("configuration goes here") + secretsUrl := "http://mysecrets.com" + + workflowIDFromString, err := GenerateWorkflowIDFromStrings(ownerHex, name, binary, config, secretsUrl) + require.NoError(t, err) + assert.NotNil(t, workflowIDFromString) + + ownerBytes, err := hex.DecodeString(ownerHex) + require.NoError(t, err) + workflowIDFromBinary, err := GenerateWorkflowID(ownerBytes, name, binary, config, secretsUrl) + require.NoError(t, err) + assert.NotNil(t, workflowIDFromBinary) + + assert.Equal(t, workflowIDFromString, hex.EncodeToString(workflowIDFromBinary[:])) +}