FIX: Import Formulas from Save Files#237
Merged
Merged
Conversation
zdomke
force-pushed
the
zdomke/formula-import
branch
from
8fca755 to
b30a6de
Compare
zdomke
force-pushed
the
zdomke/formula-import
branch
from
b30a6de to
50c7c27
Compare
jbellister-slac
approved these changes
Mar 16, 2026
jbellister-slac
left a comment
jbellister-slac
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the bug that prevented users from importing save files with formulas. The issue was just that formulas were not being addressed properly in
ControlPanel.set_curves(). This PR checks if the given curve dictionary includes a "formula" key that should match the format of trace's save files.I also updated the example save file for formulas because the indexing format for curves is out of date. I updated this by saving the state of trace to the file.
Motivation
Closes #206
Screenshots
Pre-merge checklist