Description
In the types files for context that gets passed around, it's mentioned that we can add stuff to the context as a way of passing around information. Express does something similar with their Request/Response/Application, but they specifically allow you to extend their interfaces to add your own typed properties. For typescript, this is very handy.
Here's there global namespace that makes it possible: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/express-serve-static-core/index.d.ts#L15
Here's how you can add custom typed properties in a consuming app
declare global {
namespace Express {
interface Request {
context: Context;
foo: Foo;
}
}
}
which is really nice because the autocomplete works and it knows all my typings
What type of issue is this? (place an x in one of the [ ])
Requirements (place an x in each of the [ ])
Expected result:
Ability to add types to properties that have been defined in the global namespace to things that are typically passed through handlers, Context would be my suggestion, but other interfaces would also be welcome.
Extending the interface like above should then smartly apply the correct types to extra properties that people define.
Actual result:
Types are not applied today. Any extra properties assigned to the context variable are typed any. To get typing back, we have to force casting to a class/interface.
Attachments:
Description
In the types files for
contextthat gets passed around, it's mentioned that we can add stuff to the context as a way of passing around information. Express does something similar with theirRequest/Response/Application, but they specifically allow you to extend their interfaces to add your own typed properties. For typescript, this is very handy.Here's there global namespace that makes it possible: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/express-serve-static-core/index.d.ts#L15
Here's how you can add custom typed properties in a consuming app
which is really nice because the autocomplete works and it knows all my typings
What type of issue is this? (place an
xin one of the[ ])Requirements (place an
xin each of the[ ])Expected result:
Ability to add types to properties that have been defined in the global namespace to things that are typically passed through handlers,
Contextwould be my suggestion, but other interfaces would also be welcome.Extending the interface like above should then smartly apply the correct types to extra properties that people define.
Actual result:
Types are not applied today. Any extra properties assigned to the
contextvariable are typedany. To get typing back, we have to force casting to a class/interface.Attachments: