Skip to content

Commit 5827f95

Browse files
committed
supporting views in contains
1 parent 6effbd0 commit 5827f95

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/join/join.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,7 @@ function _join_inner(dsl, dsr::AbstractDataset, ::Val{T}; onleft, onright, onrig
610610

611611
end
612612

613-
function _in(dsl::Dataset, dsr::AbstractDataset, ::Val{T}; onleft, onright, mapformats = [true, true], stable = false, alg = HeapSort, accelerate = false) where T
613+
function _in(dsl::AbstractDataset, dsr::AbstractDataset, ::Val{T}; onleft, onright, mapformats = [true, true], stable = false, alg = HeapSort, accelerate = false) where T
614614
isempty(dsl) && return Bool[]
615615
oncols_left = onleft
616616
oncols_right = onright

src/join/main.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,7 @@ julia> contains(main, tds, on = :g1 => :group)
495495
1
496496
```
497497
"""
498-
function Base.contains(main::Dataset, transaction::AbstractDataset; on = nothing, mapformats::Union{Bool, Vector{Bool}} = true, stable = false, alg = HeapSort, accelerate = false)
498+
function Base.contains(main::AbstractDataset, transaction::AbstractDataset; on = nothing, mapformats::Union{Bool, Vector{Bool}} = true, stable = false, alg = HeapSort, accelerate = false)
499499
on === nothing && throw(ArgumentError("`on` keyword must be specified"))
500500
if !(on isa AbstractVector)
501501
on = [on]
@@ -624,7 +624,7 @@ julia> antijoin(dsl, dsr, on = :year, mapformats = true) # Use formats for datas
624624
1 │ 2012 true
625625
```
626626
"""
627-
function DataAPI.antijoin(dsl::Dataset, dsr::AbstractDataset; on = nothing, mapformats::Union{Bool, Vector{Bool}} = true, stable = false, alg = HeapSort, accelerate = false, view = false)
627+
function DataAPI.antijoin(dsl::AbstractDataset, dsr::AbstractDataset; on = nothing, mapformats::Union{Bool, Vector{Bool}} = true, stable = false, alg = HeapSort, accelerate = false, view = false)
628628
if view
629629
Base.view(dsl, .!contains(dsl, dsr, on = on, mapformats = mapformats, stable = stable, alg = alg, accelerate = accelerate), :)
630630
else
@@ -736,7 +736,7 @@ julia> semijoin(dsl, dsr, on = :year, mapformats = true) # Use formats for datas
736736
3 │ 2020 true
737737
```
738738
"""
739-
function DataAPI.semijoin(dsl::Dataset, dsr::AbstractDataset; on = nothing, mapformats::Union{Bool, Vector{Bool}} = true, stable = false, alg = HeapSort, accelerate = false, view = false)
739+
function DataAPI.semijoin(dsl::AbstractDataset, dsr::AbstractDataset; on = nothing, mapformats::Union{Bool, Vector{Bool}} = true, stable = false, alg = HeapSort, accelerate = false, view = false)
740740
if view
741741
Base.view(dsl, contains(dsl, dsr, on = on, mapformats = mapformats, stable = stable, alg = alg, accelerate = accelerate), :)
742742
else

0 commit comments

Comments
 (0)