SK-2838: fix warn logs structure

Author: saileshwar-skyflow

skyflow/client/skyflow.py

@@ -1,10 +1,8 @@
-import warnings
 from collections import OrderedDict
-from typing_extensions import deprecated
 from skyflow import LogLevel
 from skyflow.error import SkyflowError
 from skyflow.utils import SkyflowMessages
-from skyflow.utils.logger import log_info, Logger
+from skyflow.utils.logger import log_info, log_warn, set_active_log_level, Logger
 from skyflow.utils.constants import OptionField
 from skyflow.utils.validations import validate_vault_config, validate_connection_config, validate_update_vault_config, \
     validate_update_connection_config, validate_credentials, validate_log_level
@@ -61,13 +59,9 @@ def set_log_level(self, log_level):
         self.__builder._Builder__set_log_level(log_level)
         return self
 
-    @deprecated("[DEPRECATED] Use set_log_level() instead.")
     def update_log_level(self, log_level):
-        warnings.warn(
-            SkyflowMessages.Warning.UPDATE_LOG_LEVEL_DEPRECATED.value,
-            DeprecationWarning,
-            stacklevel=2,
-        )
+        """.. deprecated:: Use set_log_level() instead. Will be removed in a future release."""
+        log_warn(SkyflowMessages.Warning.UPDATE_LOG_LEVEL_DEPRECATED.value)
         return self.set_log_level(log_level)
 
     def get_log_level(self):
@@ -227,6 +221,7 @@ def __set_log_level(self, log_level):
             validate_log_level(self.__logger, log_level)
             self.__log_level = log_level
             self.__logger.set_log_level(log_level)
+            set_active_log_level(log_level)
             self.__update_vault_client_logger(log_level, self.__logger)
             log_info(SkyflowMessages.Info.LOGGER_SETUP_DONE.value, self.__logger)
             log_info(SkyflowMessages.Info.CURRENT_LOG_LEVEL.value.format(self.__log_level), self.__logger)
@@ -243,6 +238,7 @@ def __add_skyflow_credentials(self, credentials):
         def build(self):
             validate_log_level(self.__logger, self.__log_level)
             self.__logger.set_log_level(self.__log_level)
+            set_active_log_level(self.__log_level)
 
             for config in self.__vault_list:
                 self.__add_vault_config(config)

skyflow/utils/_skyflow_messages.py

@@ -4,6 +4,7 @@
 
 error_prefix = f"Skyflow Python SDK {SDK_VERSION}"
 INFO = "INFO"
+WARN = "WARN"
 ERROR = "ERROR"
 
 class SkyflowMessages:
@@ -417,11 +418,11 @@ class HttpStatus(Enum):
 
     class Warning(Enum):
         UPDATE_LOG_LEVEL_DEPRECATED = (
-            "[DEPRECATED] Skyflow.update_log_level() is deprecated. "
-            "Use Skyflow.set_log_level() instead — identical behavior."
+            f"{WARN}: [{error_prefix}] Skyflow.update_log_level() is deprecated. "
+            "Use Skyflow.set_log_level() instead."
         )
         FILE_UPLOAD_REQUEST_ARG_ORDER_DEPRECATED = (
-            "[DEPRECATED] FileUploadRequest: argument order changed. "
+            f"{WARN}: [{error_prefix}] FileUploadRequest: argument order changed. "
             "Old positional order: (table, skyflow_id, column_name). "
             "New order: FileUploadRequest(table, column_name=..., skyflow_id=...)."
         )

skyflow/utils/logger/__init__.py

@@ -1,2 +1,2 @@
 from ._logger import Logger
-from ._log_helpers import log_error, log_info, log_error_log
+from ._log_helpers import log_error, log_info, log_warn, log_error_log, set_active_log_level

skyflow/utils/logger/_log_helpers.py

@@ -2,13 +2,25 @@
 from . import Logger
 from ..constants import ResponseField
 
+_active_log_level = LogLevel.ERROR
+
+
+def set_active_log_level(level):
+    global _active_log_level
+    _active_log_level = level
+
 
 def log_info(message, logger = None):
     if not logger:
         logger = Logger(LogLevel.INFO)
 
     logger.info(message)
 
+def log_warn(message, logger=None):
+    if not logger:
+        logger = Logger(_active_log_level)
+    logger.warn(message)
+
 def log_error_log(message, logger=None):
     if not logger:
         logger = Logger(LogLevel.ERROR)

skyflow/vault/data/_file_upload_request.py

@@ -1,7 +1,7 @@
-import warnings
 from typing import BinaryIO, Optional
 
 from skyflow.utils import SkyflowMessages
+from skyflow.utils.logger import log_warn
 
 
 class FileUploadRequest:
@@ -15,12 +15,7 @@ def __init__(self,
                  file_object: Optional[BinaryIO] = None,
                  file_name: Optional[str] = None):
         if args:
-            warnings.warn(
-                SkyflowMessages.Warning.FILE_UPLOAD_REQUEST_ARG_ORDER_DEPRECATED.value,
-                DeprecationWarning,
-                stacklevel=2,
-            )
-            # Old positional order was: (table, skyflow_id, column_name, ...)
+            log_warn(SkyflowMessages.Warning.FILE_UPLOAD_REQUEST_ARG_ORDER_DEPRECATED.value)
             skyflow_id = args[0] if args else skyflow_id
             column_name = args[1] if len(args) > 1 else column_name
         self.table = table