Skip to content

Commit ee167b4

Browse files
test: add positive tests for permissive Insert validation behaviour
Three new tests assert that previously-blocked inputs now pass SDK validation (SDK defers to BE per API spec additionalProperties: Any type): - Empty values array [] passes - Null field value passes - Empty string field value passes Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
1 parent bff8b52 commit ee167b4

1 file changed

Lines changed: 37 additions & 0 deletions

File tree

src/test/java/com/skyflow/vault/data/InsertTests.java

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,43 @@ public void testNoValuesInInsertRequestValidations() {
171171
}
172172
}
173173

174+
@Test
175+
public void testEmptyValuesArrayPassesInsertRequestValidations() {
176+
// SDK no longer blocks empty values array — BE is authoritative
177+
InsertRequest request = InsertRequest.builder().table(table).values(values).build();
178+
try {
179+
Validations.validateInsertRequest(request);
180+
} catch (SkyflowException e) {
181+
Assert.fail("Empty values array should pass SDK validation: " + e.getMessage());
182+
}
183+
}
184+
185+
@Test
186+
public void testNullFieldValuePassesInsertRequestValidations() {
187+
// SDK no longer blocks null field values — BE is authoritative per API spec
188+
valueMap.put("test_column_1", null);
189+
values.add(valueMap);
190+
InsertRequest request = InsertRequest.builder().table(table).values(values).build();
191+
try {
192+
Validations.validateInsertRequest(request);
193+
} catch (SkyflowException e) {
194+
Assert.fail("Null field value should pass SDK validation: " + e.getMessage());
195+
}
196+
}
197+
198+
@Test
199+
public void testEmptyStringFieldValuePassesInsertRequestValidations() {
200+
// SDK no longer blocks empty string field values — BE is authoritative per API spec
201+
valueMap.put("test_column_1", "");
202+
values.add(valueMap);
203+
InsertRequest request = InsertRequest.builder().table(table).values(values).build();
204+
try {
205+
Validations.validateInsertRequest(request);
206+
} catch (SkyflowException e) {
207+
Assert.fail("Empty string field value should pass SDK validation: " + e.getMessage());
208+
}
209+
}
210+
174211
@Test
175212
public void testEmptyKeyInValuesInInsertRequestValidations() {
176213
valueMap.put("", "test_value_3");

0 commit comments

Comments
 (0)