Skip to content

Commit a802668

Browse files
fix: guard against null in DetokenizeRequest.downloadUrl(null)
Calling .downloadUrl(null) previously stored null in the field, creating an NPE risk for callers who read getDownloadUrl() back without a null check. Now null -> false (matching the default), consistent with the continueOnError(null) guard in the same builder. Added test: testDetokenizeRequestDownloadUrlNullTreatedAsFalse Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
1 parent 5acbb84 commit a802668

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

src/main/java/com/skyflow/vault/tokens/DetokenizeRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public DetokenizeRequestBuilder downloadURL(Boolean downloadURL) {
6767
}
6868

6969
public DetokenizeRequestBuilder downloadUrl(Boolean downloadUrl) {
70-
this.downloadUrl = downloadUrl;
70+
this.downloadUrl = downloadUrl != null && downloadUrl;
7171
return this;
7272
}
7373

src/test/java/com/skyflow/vault/controller/VaultControllerTests.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,4 +291,12 @@ public void testDetokenizeRequestDownloadUrlDefaultIsFalse() {
291291
Assert.assertFalse("downloadUrl should be false by default", request.getDownloadUrl());
292292
}
293293

294+
@Test
295+
public void testDetokenizeRequestDownloadUrlNullTreatedAsFalse() {
296+
DetokenizeRequest request = DetokenizeRequest.builder()
297+
.downloadUrl(null)
298+
.build();
299+
Assert.assertFalse("null downloadUrl should default to false — no NPE risk", request.getDownloadUrl());
300+
}
301+
294302
}

0 commit comments

Comments
 (0)