Skip to content

Commit 162e61d

Browse files
Merge pull request #140 from skyflowapi/SK-1786-common-workflow-for-v2
SK-1786 test common workflow
2 parents 6d23922 + 0b33663 commit 162e61d

2 files changed

Lines changed: 14 additions & 20 deletions

File tree

.github/workflows/internal-release.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,11 @@ jobs:
1515
ref: ${{ github.ref_name }}
1616
is-internal: true
1717
server-id: central
18+
profile: jfrog
19+
secrets:
1820
server-username: ${{ secrets.ARTIFACTORY_USERNAME }}
1921
server-password: ${{ secrets.ARTIFACTORY_PASSWORD }}
2022
gpg-key: ${{ secrets.JFROG_GPG_KEY }}
2123
gpg-passphrase: ${{ secrets.JFROG_GPG_PASSPHRASE }}
22-
profile: jfrog
24+
25+

.github/workflows/shared-build-and-deploy.yml

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,31 +16,23 @@ on:
1616
description: 'Id of the repository'
1717
required: true
1818
type: string
19-
20-
server-username:
21-
description: 'Username of the repository'
19+
20+
profile:
21+
description: 'Profile to pick from pom.xml'
2222
required: true
2323
type: string
24+
secrets:
25+
server-username:
26+
required: true
2427

2528
server-password:
26-
description: 'Password of the repository'
2729
required: true
28-
type: string
2930

3031
gpg-key:
31-
description: 'GPG key to access the repository'
3232
required: true
33-
type: string
3433

3534
gpg-passphrase:
36-
description: 'GPG passphrase to access the repository'
3735
required: true
38-
type: string
39-
40-
profile:
41-
description: 'Profile to pick from pom.xml'
42-
required: true
43-
type: string
4436

4537
jobs:
4638
publish:
@@ -59,7 +51,7 @@ jobs:
5951
server-id: ${{ inputs.server-id }}
6052
server-username: SERVER_USERNAME
6153
server-password: SERVER_PASSWORD
62-
gpg-private-key: ${{ inputs.gpg-key }} # Value of the GPG private key to import
54+
gpg-private-key: ${{ secrets.gpg-key }} # Value of the GPG private key to import
6355
gpg-passphrase: GPG_PASSPHRASE # env variable for GPG private key passphrase
6456

6557
- name: Get Previous tag
@@ -107,7 +99,6 @@ jobs:
10799
- name: Publish package
108100
run: mvn clean deploy -P ${{ inputs.profile }}
109101
env:
110-
SERVER_USERNAME: ${{ inputs.server-username }}
111-
SERVER_PASSWORD: ${{ inputs.server-password }}
112-
GPG_PASSPHRASE: ${{ inputs.gpg-passphrase }}
113-
102+
SERVER_USERNAME: ${{ secrets.server-username }}
103+
SERVER_PASSWORD: ${{ secrets.server-password }}
104+
GPG_PASSPHRASE: ${{ secrets.gpg-passphrase }}

0 commit comments

Comments
 (0)